fix ATA toplevel dep detection#47164
Merged
zkat merged 1 commit intomicrosoft:mainfrom Jan 7, 2022
Merged
Conversation
typescript-bot
added
the
For Milestone Bug
zkat
force-pushed
the
zkat/portable-typings-installer-filtering
branch
2 times, most recently
from
10228e6 to
f1feb45
Compare
minestarks
reviewed
Dec 16, 2021
andrewbranch
approved these changes
Dec 16, 2021
zkat
force-pushed
the
zkat/portable-typings-installer-filtering
branch
3 times, most recently
from
54b4c3d to
f73bf36
Compare
Contributor
Author
|
Alright, this is ready for another look-see :) |
minestarks
approved these changes
Jan 7, 2022
Member
minestarks
left a comment
minestarks
left a comment
There was a problem hiding this comment.
Nice to see scoped package handling too!
ATA tried to use the `_requiredBy` field to determine toplevel deps, but this is not portable. Not only is it unavailable in npm@>=7, but neither Yarn nor pnpm write this metadata to node_modules pkgjsons. This also adds support for ATA acquiring types for scoped packages. Fixes: microsoft#44130
zkat
force-pushed
the
zkat/portable-typings-installer-filtering
branch
from
f73bf36 to
f50c15a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATA tried to use the
_requiredByfield to determine toplevel deps,but this is not portable. Not only is it unavailable in npm@>=7, but
neither Yarn nor pnpm write this metadata to node_modules pkgjsons.
This patch changes that such that we do the only portable thing: Read
the toplevel package.json itself, collect its dependencies, and then just
take a look at the toplevel node_modules dependencies and filter based
on that.
Fixes: #44130