Ignore bad typings properties in package.json files#46877
Closed
amcasey wants to merge 1 commit intomicrosoft:mainfrom
Closed
Ignore bad typings properties in package.json files#46877amcasey wants to merge 1 commit intomicrosoft:mainfrom
amcasey wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Otherwise, the non-existent typings file becomes part of the project and a spurious non-existent-root-file error is reported.
Member
Author
|
Moot |
5b8bc88 to
90d1335
Compare
zkat
approved these changes
Dec 17, 2021
Member
|
@amcasey - is there more work to do on this? |
Contributor
|
Closing in favor of #47164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the non-existent typings file becomes part of the project and a spurious non-existent-root-file error is reported.
This was reported by a customer using source-map.
This is pretty rare, but we could go above and beyond by trying to add the file extension ourselves.