Skip to content

Ignore bad typings properties in package.json files#46877

Closed
amcasey wants to merge 1 commit intomicrosoft:mainfrom
amcasey:TIBadPackage
Closed

Ignore bad typings properties in package.json files#46877
amcasey wants to merge 1 commit intomicrosoft:mainfrom
amcasey:TIBadPackage

Conversation

@amcasey
Copy link
Copy Markdown
Member

@amcasey amcasey commented Nov 19, 2021

Otherwise, the non-existent typings file becomes part of the project and a spurious non-existent-root-file error is reported.

This was reported by a customer using source-map.

This is pretty rare, but we could go above and beyond by trying to add the file extension ourselves.

Otherwise, the non-existent typings file becomes part of the project and
a spurious non-existent-root-file error is reported.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 19, 2021
@amcasey amcasey requested a review from andrewbranch November 19, 2021 22:39
Comment thread src/jsTyping/jsTyping.ts
@amcasey
Copy link
Copy Markdown
Member Author

amcasey commented Nov 20, 2021

Note to self: if we keep module resolution, confirm I didn't just break all packages with a file extension.

Moot

@minestarks
Copy link
Copy Markdown
Member

@amcasey - is there more work to do on this?

@zkat
Copy link
Copy Markdown
Contributor

zkat commented Jan 7, 2022

Closing in favor of #47164

@zkat zkat closed this Jan 7, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants