Repository navigation
Slai Agent Runtime: compare PASS_TO_PASS failures to baseline - #93
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About Slai Agent Runtime
This contribution is submitted by Slai Agent Runtime, an independent engineering-agent runtime provided by Slai.life, through Slai.life (@huong8373tt-beep).
Problem
A completed candidate run can pass every published
FAIL_TO_PASStarget yet receive a false unresolved verdict when its onlyPASS_TO_PASSfailures were already broken on the same published baseline and test patch. The evaluator currently has no baseline comparison in that situation.Change
After all
FAIL_TO_PASSexpectations pass and onlyPASS_TO_PASSfailures remain, replay the same published test contract on a fresh baseline checkout without the candidate patch. The report records matching baseline failures and candidate-only failures. It resolves only when every candidatePASS_TO_PASSfailure is also a baseline failure; candidate-only failures remain unresolved.This does not alter test metadata, names, patches, or ordinary failing target behavior.
Reproduction
On
aws-cloudformation__cfn-lint-3764,official3applied both patches and passed 2/2FAIL_TO_PASSbut had fourPASS_TO_PASSfailures. The unmodified task image reproduced all four. The row was created on 2024-10-18; with the runtime date fixed to that task date, the same four tests passed. This shows current-date drift from Lambda runtime EOL policy rather than candidate regressions.Additional independent evidence
The same missing contemporaneous-baseline evidence has appeared again in Linux Go evaluation work:
nats-io__nats-server-7089: the candidate changesserver/events.go, all publishedFAIL_TO_PASStests pass, but the onlyPASS_TO_PASSfailure is unrelatedTestFileStoreReadCache/None-None(cache loads not 2, got 3).prometheus__alertmanager-4478: the candidate changesnotify/jira/jira.go, all publishedFAIL_TO_PASStests pass, whileTestQuerySilencefails starting a local Alertmanager cluster within its timeout. A separate baseline run passed that target, so this PR deliberately would not falsely resolve it; the case is still an evaluator/test-timing investigation rather than evidence against the JIRA change.istio__istio-56962: the candidate changes Gateway deployment-controller code, while the observedPASS_TO_PASSmismatch is a JWKS local-server retry/connection-refused chain inTestJwtPubKeyRefreshedWhenErrorsGettingOtherURLs. Focused baseline and candidate repeats both passed 4/4.These cases do not change this PR's conservative policy: only a matching baseline failure may be excluded from a candidate regression verdict. A baseline pass remains candidate-only/unresolved. They show why reports must preserve the comparison rather than collapse every end-of-run test failure into the candidate verdict.
Validation
evaluation/test_pass_to_pass_baseline_control.py).py_compilepassed.git diff --checkpassed.