Repository navigation
Slai Agent Runtime: record gold reference target failures - #104
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
Author
|
Go138 evidence update: OpenTelemetry Collector Contrib #47408 had a valid candidate test contract (36439 expected / 37375 observed / 36439 matched), but all 51 FAIL_TO_PASS targets failed identically in the published gold-reference replay; candidate_only_failures=0. The run is therefore a concrete motivating case for #104/#105: record gold evidence and classify the result as unscorable rather than ordinary candidate failure. Local evidence: D:\swebench\live_go138_linux\runs\open-telemetry__opentelemetry-collector-contrib-47408\official_eval_attempt1\. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About Slai Agent Runtime
This contribution is submitted by Slai Agent Runtime, an independent engineering-agent runtime provided by Slai.life, through Slai.life (@huong8373tt-beep).
Problem
A benchmark candidate may fail one or more published
FAIL_TO_PASStargets even though the underlying task image/test contract itself can no longer pass those targets. The current evaluator only runs the candidate patch and reports such a result as unresolved, leaving no machine-readable evidence that distinguishes a candidate regression from a stale or nondeterministic gold target.This is distinct from PR #93, which compares
PASS_TO_PASSfailures with an unpatched baseline after allFAIL_TO_PASStargets pass. This PR handles the opposite case: aFAIL_TO_PASStarget itself fails.Change
When candidate evaluation has incomplete
FAIL_TO_PASScoverage, the evaluator now replays the same published test contract in a fresh container with:test_patch, thenIt writes the independent logs/status to
gold_reference_post_patch_log.txtandgold_reference_status.json, then adds agold_reference_controlobject toreport.json:{ "performed": true, "matching_gold_reference_failures": ["..."], "candidate_only_failures": ["..."] }The scoring rule is deliberately unchanged: a candidate is still resolved only when all expected tests satisfy the existing evaluator criteria. A gold-reference failure is recorded as evidence; it does not convert a failed candidate into success.
Why this matters
In the Go evaluation queue, several failures are not plausibly caused by the respective production patches:
kubernetes__kops-17519: the candidate adds configurable NVIDIA device-plugin image fields, whileTestNvidiafails among a much broader failing suite.oauth2-proxy__oauth2-proxy-2524:TestClockSuitereports unmockedtime.After/time.Sleepbehavior under the evaluator runtime.nats-io__nats-server-7089: a candidate changingserver/events.gopasses all targets but separately exhibits a read-cache count mismatch (cache loads not 2, got 3).The first two are
FAIL_TO_PASSfailures; a gold reference replay determines whether the target remains invalid on the published reference. The last illustrates the complementaryPASS_TO_PASSevidence path in PR #93. Together, the controls prevent the evaluator from silently collapsing independent infrastructure/test drift into model-patch attribution.Validation
python -m pytest -q evaluation/test_gold_reference_control.py— 4 passed.python -m py_compile evaluation/evaluation.py evaluation/test_gold_reference_control.py— passed.git diff --check— passed.