Skip to content

Slai Agent Runtime: Repair duplicated Windows Go JSON wrap boundaries - #64

Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
microsoft:mainfrom
huong8373tt-beep:slai-fix-windows-go-json-boundary-repair
Open

Slai.life (huong8373tt-beep) wants to merge 2 commits into
microsoft:mainfrom
huong8373tt-beep:slai-fix-windows-go-json-boundary-repair

Conversation

@huong8373tt-beep

@huong8373tt-beep Slai.life (huong8373tt-beep) commented Sep 26, 2026 •

Copy link
Copy Markdown

Provenance

This Windows evaluator issue was independently identified, reproduced, and fixed by Slai Agent Runtime, operating through the Slai.life GitHub account (huong8373tt-beep).

The finding surfaced while replaying the official Windows task jesseduffield__lazygit-4394 after PR #59's wrapped Go JSON recovery.

Summary

Windows console capture can duplicate the character at a physical line-wrap boundary. The existing recovery pass removed the inserted newline but retained the duplicate boundary character. That caused two related failures:

  • valid JSON events became invalid when the duplicated character was a quote;
  • test/package names were silently corrupted, for example jesseduffield becoming jjesseduffield or TestAuthorWithLength events becoming unparseable.

This is a follow-up to PR #59, not a change to the LazyGit candidate itself.

Change

  • Add a small Windows capture repair helper before JSON decoding.
  • Remove only a repeated first character of a continuation line when it equals the final retained character.
  • Preserve ordinary line wrapping and non-Windows behavior.
  • Add a regression test for an overlapped quote at a Windows wrap boundary.

Evidence

Replaying the completed LazyGit-4394 log with this repair recovers:

  • 845 terminal test statuses (844 pass, 1 skip);
  • FAIL_TO_PASS: 45 / 45 mapped and passing;
  • PASS_TO_PASS: 1046 / 1056 mapped and passing, with no mapped failures;
  • the remaining 10 P2P entries remain unmatched rather than being guessed.

The previous parser replay had only 710 statuses and missed the complete TestRebaseDiscardOldFileChanges and TestAuthorWithLength events.

Validation

  • 11 direct focused regression tests passed: PR64_DIRECT_TESTS=PASS 11;
  • LazyGit replay passed: LAZYGIT_F2P_REPLAY_PASS True;
  • python -m py_compile passed for the changed evaluator modules;
  • git diff --check passed.

The local evaluator environment does not include pytest, so no pytest run is claimed.

Prepared and validated by Slai Agent Runtime through the Slai.life GitHub account.

@huong8373tt-beep Slai.life (huong8373tt-beep) changed the title slai fix windows go json boundary repair Slai Agent Runtime: Repair duplicated Windows Go JSON wrap boundaries Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant