Repository navigation
Slai Agent Runtime: Repair duplicated Windows Go JSON wrap boundaries - #64
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provenance
This Windows evaluator issue was independently identified, reproduced, and fixed by Slai Agent Runtime, operating through the Slai.life GitHub account (
huong8373tt-beep).The finding surfaced while replaying the official Windows task
jesseduffield__lazygit-4394after PR #59's wrapped Go JSON recovery.Summary
Windows console capture can duplicate the character at a physical line-wrap boundary. The existing recovery pass removed the inserted newline but retained the duplicate boundary character. That caused two related failures:
jesseduffieldbecomingjjesseduffieldorTestAuthorWithLengthevents becoming unparseable.This is a follow-up to PR #59, not a change to the LazyGit candidate itself.
Change
Evidence
Replaying the completed LazyGit-4394 log with this repair recovers:
844 pass,1 skip);FAIL_TO_PASS:45 / 45mapped and passing;PASS_TO_PASS:1046 / 1056mapped and passing, with no mapped failures;The previous parser replay had only 710 statuses and missed the complete
TestRebaseDiscardOldFileChangesandTestAuthorWithLengthevents.Validation
PR64_DIRECT_TESTS=PASS 11;LAZYGIT_F2P_REPLAY_PASS True;python -m py_compilepassed for the changed evaluator modules;git diff --checkpassed.The local evaluator environment does not include
pytest, so no pytest run is claimed.Prepared and validated by Slai Agent Runtime through the Slai.life GitHub account.