Skip to content

fix: circular ref guard (#3033) - #3039

Merged
Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/circular-ref-guard-to-v2
Aug 19, 2026
Merged

fix: circular ref guard (#3033)#3039
Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/circular-ref-guard-to-v2

Conversation

@baywet

Copy link
Copy Markdown
Member

port of #3033 to v2

* fix: harden yaml parsing

* fix tests and nesting behavior on streams with SharpYaml update

* CodeQL fixes

* update benchmarks

* fix: circular ref guard

* update benchmarks

* fix: harden yaml parsing

* fix tests and nesting behavior on streams with SharpYaml update

* CodeQL fixes

* update benchmarks

* fix: circular ref guard

* update benchmarks

* codeql updates

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner August 19, 2026 12:53
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) August 19, 2026 12:54
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@github-code-quality

github-code-quality Bot commented Aug 19, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in commit b0b0084 in the fix/circular-ref-gua... branch is 41%. The coverage in commit 8018d40 in the support/v2 branch is 89%.

Show a code coverage summary of the most impacted files.
File support/v2 8018d40 fix/circular-ref-gua... b0b0084 +/-
/home/runner/wo...MapParameter.cs 100% 0% -100%
/home/runner/wo...Deserializer.cs 81% 0% -81%
/home/runner/wo...pyReferences.cs 63% 31% -32%
/home/runner/wo...piJsonReader.cs 100% 72% -28%
/home/runner/wo...Deserializer.cs 90% 62% -28%
/home/runner/wo...s/OpenApiTag.cs 100% 76% -24%
/home/runner/wo...Deserializer.cs 100% 81% -19%
/home/runner/wo...Deserializer.cs 96% 81% -15%
/home/runner/wo...Deserializer.cs 97% 89% -8%
/home/runner/wo...piComponents.cs 94% 87% -7%

Updated August 19, 2026 14:45 UTC

@sonarqubecloud

Copy link
Copy Markdown

@baywet
Vincent Biret (baywet) merged commit 406e6fd into support/v2 Aug 19, 2026
17 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/circular-ref-guard-to-v2 branch August 19, 2026 15:23
This was referenced Aug 22, 2026
Martin Volek (vdolek) pushed a commit to EvilBrainsTechnology/EvilCase that referenced this pull request Aug 23, 2026
Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET)
from 2.11.0 to 2.12.2.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.OpenApi's
releases](https://github.com/Microsoft/OpenAPI.NET/releases)._

## 2.12.2

##
[2.12.2](microsoft/OpenAPI.NET@v2.12.1...v2.12.2)
(2026-08-20)


### Bug Fixes

* duplicate schema example when serializing to v2
([#​3046](microsoft/OpenAPI.NET#3046))
([a6366be](microsoft/OpenAPI.NET@a6366be))

## 2.12.1

##
[2.12.1](microsoft/OpenAPI.NET@v2.12.0...v2.12.1)
(2026-08-19)


### Bug Fixes

* circular ref guard
([#​3033](microsoft/OpenAPI.NET#3033))
([#​3039](microsoft/OpenAPI.NET#3039))
([406e6fd](microsoft/OpenAPI.NET@406e6fd))
* harden yaml parsing
([#​3034](microsoft/OpenAPI.NET#3034))
([fdc5718](microsoft/OpenAPI.NET@fdc5718))

## 2.12.0

##
[2.12.0](microsoft/OpenAPI.NET@v2.11.0...v2.12.0)
(2026-08-12)


### Features

* adds deserialization of the example extension
([095ae3b](microsoft/OpenAPI.NET@095ae3b))
* serialize license identifier as extension for earlier versions
([d5cdce8](microsoft/OpenAPI.NET@d5cdce8))
* serialize license identifier as extension for earlier versions
([fde38d8](microsoft/OpenAPI.NET@fde38d8))


### Bug Fixes

* better nullability round-tripping
([7a25659](microsoft/OpenAPI.NET@7a25659))
* bound YAML anchor/alias expansion to prevent OOM (billion laughs)
([#​3000](microsoft/OpenAPI.NET#3000))
([a361360](microsoft/OpenAPI.NET@a361360))
* bound YAML anchor/alias expansion to prevent OOM (billion laughs)
([#​3000](microsoft/OpenAPI.NET#3000))
([4db9af0](microsoft/OpenAPI.NET@4db9af0))
* **library:** serialize multiple schema types as anyOf/oneOf for
OpenAPI 3.0
([6568896](microsoft/OpenAPI.NET@6568896))
* marks deprecated properties from the specification as obsolete
([26aba69](microsoft/OpenAPI.NET@26aba69))
* marks deprecated properties from the specification as obsolete
([abc5301](microsoft/OpenAPI.NET@abc5301))
* **schema:** serialize compatibility examples from examples list
([be57a7c](microsoft/OpenAPI.NET@be57a7c))
* serialize examples as extension in v2/v3
([d27141b](microsoft/OpenAPI.NET@d27141b))

Commits viewable in [compare
view](microsoft/OpenAPI.NET@v2.11.0...v2.12.2).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.OpenApi&package-manager=nuget&previous-version=2.11.0&new-version=2.12.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants