fix: circular ref guard by gavinbarron · Pull Request #3033 · microsoft/OpenAPI.NET

Gavin Barron (gavinbarron) · 2026-08-19T01:47:57Z

Pull Request

Description

improved circular ref detection

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Other (please describe):

Related Issue(s)

Changes Made

improved parsing perf

Testing

Unit tests added/updated
Integration tests added/updated
Manual testing performed
All existing tests pass

Checklist

My code follows the code style of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Versions applicability

My change applies to the version 1.X of the library, if so PR link:
My change applies to the version 2.X of the library, if so PR link:
My change applies to the version 3.X of the library, if so PR link:
I have evaluated the applicability of my change against the other versions above.

See the contributing guidelines for more information about how patches are applied across multiple versions.

Additional Notes

…e-stack-overflow

github-code-quality · 2026-08-19T01:49:34Z

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in commit 419868b in the fix/circular-ref-gua... branch remains at 89%, unchanged from commit e0d5e9d in the main branch.

Show a code coverage summary of the most impacted files.

File	`main` e0d5e9d	`fix/circular-ref-gua...` 419868b	+/-
`/home/runner/wo...erenceHolder.cs`	100%	95%	-5%
`/home/runner/wo...nApiDocument.cs`	89%	89%	0%
`/home/runner/wo...ackReference.cs`	45%	45%	0%
`/home/runner/wo...pleReference.cs`	67%	67%	0%
`/home/runner/wo...derReference.cs`	80%	80%	0%
`/home/runner/wo...inkReference.cs`	69%	69%	0%
`/home/runner/wo...ypeReference.cs`	79%	79%	0%
`/home/runner/wo...terReference.cs`	82%	82%	0%
`/home/runner/wo...temReference.cs`	65%	65%	0%
`/home/runner/wo...TagReference.cs`	65%	74%	+9%

_{Updated August 19, 2026 03:05 UTC}

…/OpenAPI.NET into fix/circular-ref-guard

sonarqubecloud · 2026-08-19T03:09:02Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.4% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

* fix: circular ref guard (#3033) * fix: harden yaml parsing * fix tests and nesting behavior on streams with SharpYaml update * CodeQL fixes * update benchmarks * fix: circular ref guard * update benchmarks * fix: harden yaml parsing * fix tests and nesting behavior on streams with SharpYaml update * CodeQL fixes * update benchmarks * fix: circular ref guard * update benchmarks * codeql updates Signed-off-by: Vincent Biret <vibiret@microsoft.com> * chore: removes invalid property test due to bad cherry-pick Signed-off-by: Vincent Biret <vibiret@microsoft.com> * chore: refreshes performance reports --------- Signed-off-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>

Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 2.12.0 to 2.12.2. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.12.2 ## [2.12.2](microsoft/OpenAPI.NET@v2.12.1...v2.12.2) (2026-08-20) ### Bug Fixes * duplicate schema example when serializing to v2 ([#3046](microsoft/OpenAPI.NET#3046)) ([a6366be](microsoft/OpenAPI.NET@a6366be)) ## 2.12.1 ## [2.12.1](microsoft/OpenAPI.NET@v2.12.0...v2.12.1) (2026-08-19) ### Bug Fixes * circular ref guard ([#3033](microsoft/OpenAPI.NET#3033)) ([#3039](microsoft/OpenAPI.NET#3039)) ([406e6fd](microsoft/OpenAPI.NET@406e6fd)) * harden yaml parsing ([#3034](microsoft/OpenAPI.NET#3034)) ([fdc5718](microsoft/OpenAPI.NET@fdc5718)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.12.0...v2.12.2). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.OpenApi&package-manager=nuget&previous-version=2.12.0&new-version=2.12.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Pinned [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) at 2.12.2. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.12.2 ## [2.12.2](microsoft/OpenAPI.NET@v2.12.1...v2.12.2) (2026-08-20) ### Bug Fixes * duplicate schema example when serializing to v2 ([#3046](microsoft/OpenAPI.NET#3046)) ([a6366be](microsoft/OpenAPI.NET@a6366be)) ## 2.12.1 ## [2.12.1](microsoft/OpenAPI.NET@v2.12.0...v2.12.1) (2026-08-19) ### Bug Fixes * circular ref guard ([#3033](microsoft/OpenAPI.NET#3033)) ([#3039](microsoft/OpenAPI.NET#3039)) ([406e6fd](microsoft/OpenAPI.NET@406e6fd)) * harden yaml parsing ([#3034](microsoft/OpenAPI.NET#3034)) ([fdc5718](microsoft/OpenAPI.NET@fdc5718)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.12.0...v2.12.2). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Gavin Barron (gavinbarron) added 6 commits August 18, 2026 13:56

fix: harden yaml parsing

79ed241

fix tests and nesting behavior on streams with SharpYaml update

a327d7f

CodeQL fixes

51cf449

update benchmarks

684c8d6

fix: circular ref guard

3684ccb

Merge remote-tracking branch 'origin/main' into fix/circular-referenc…

748d2ac

…e-stack-overflow

Gavin Barron (gavinbarron) requested a review from a team as a code owner August 19, 2026 01:47

github-code-quality Bot found potential problems Aug 19, 2026

View reviewed changes

Comment thread test/Microsoft.OpenApi.Tests/Models/References/OpenApiSchemaReferenceTests.cs Fixed

Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed

Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed

github-advanced-security Bot found potential problems Aug 19, 2026

View reviewed changes

Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed

Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed

Gavin Barron (gavinbarron) mentioned this pull request Aug 19, 2026

fix: harden yaml parsing #3034

Merged

Gavin Barron (gavinbarron) changed the title ~~Fix/circular ref guard~~ fix: circular ref guard Aug 19, 2026

Gavin Barron (gavinbarron) added 9 commits August 18, 2026 19:18

update benchmarks

5f49f5b

fix: harden yaml parsing

84f1ccb

fix tests and nesting behavior on streams with SharpYaml update

bad9d50

CodeQL fixes

d09dff2

update benchmarks

130a0d4

fix: circular ref guard

0f07ae1

update benchmarks

8327de5

codeql updates

f67e81b

Merge branch 'fix/circular-ref-guard' of https://github.com/microsoft…

419868b

…/OpenAPI.NET into fix/circular-ref-guard

Vincent Biret (baywet) approved these changes Aug 19, 2026

View reviewed changes

Vincent Biret (baywet) merged commit 8018d40 into main Aug 19, 2026
19 checks passed

Vincent Biret (baywet) deleted the fix/circular-ref-guard branch August 19, 2026 12:36

release-please-token-provider Bot mentioned this pull request Aug 19, 2026

chore(main): release 3.10.1 #3032

Merged

Vincent Biret (baywet) mentioned this pull request Aug 19, 2026

fix: circular ref guard (#3033) #3039

Merged

release-please-token-provider Bot mentioned this pull request Aug 19, 2026

chore(support/v2): release 2.12.1 #3038

Merged

dependabot Bot mentioned this pull request Aug 19, 2026

Bump the dotnet group with 8 updates IEvangelist/pwned-client#97

Open

Navigation Menu

Uh oh!

fix: circular ref guard - #3033

fix: circular ref guard#3033
Vincent Biret (baywet) merged 15 commits into
mainfrom
fix/circular-ref-guard

Gavin Barron (gavinbarron) commented Aug 19, 2026

Uh oh!

github-code-quality Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Gavin Barron (gavinbarron) commented Aug 19, 2026

Pull Request

Description

Type of Change

Related Issue(s)

Changes Made

Testing

Checklist

Versions applicability

Additional Notes

Uh oh!

github-code-quality Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

C# / code-coverage/dotnet

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 19, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-code-quality Bot commented Aug 19, 2026 •

edited

Loading