Repository navigation
ci: delete the pull-request contract workflows replaced by ci-status - #530
Conversation
The `pr-contract` composite has run as a step inside the required `ci-status` job since standards#526 merged, and the org `ci-gate` ruleset now requires only `ci-status` on `main`, so the three standalone callers emit contexts nothing depends on and pay for runners twice on every pull-request event. Delete `.github/workflows/pr-title.yml`, `.github/workflows/do-not-merge.yml` and `.github/workflows/pr-issue-linkage.yml`. The `exempt-authors` value the linkage caller carried, `dependabot[bot]`, already sits on the `pr-contract` step in `ci.yml`, so nothing changes for Dependabot. Both deleted `pull_request_target` workflows go with them, leaving no `pull_request_target` trigger anywhere in this repository. Three repository-owned sentences named the deleted files or the retired reusable as the enforcing gate; they now name the `pr-contract` composite inside `ci-status` and record that the body and linkage contract is advisory, an upserted comment plus the `needs-issue-linkage` label, not a red check. The ci-workflows reusables `semantic-pr.yml`, `do-not-merge-gate.yml` and `pr-issue-linkage.yml` are untouched; only this repository's callers go. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019APkoJh8NVN773d82fBBSG
|
Claude finished @kyle-sexton's task in 1m 43s —— View job Code review complete
Scope: clean deletion of three now-redundant standalone required checks ( Verification performed:
No correctness or maintainability issues found — no inline comments filed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 960e0e55c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No related issue: melodic-software/github-iac#396 tracks Phase 3 of the ci-perf program
Summary
Since standards#526 merged, the
pr-contractcomposite runs as a step inside the requiredci-statusjob, and Phase 3.3 (github-iac run 33954697296) narrowed the orgci-gateruleset soci-statusis the only required context onmain. The three standalone callers.github/workflows/pr-title.yml,.github/workflows/do-not-merge.ymland.github/workflows/pr-issue-linkage.ymltherefore emit contexts nothing depends on while paying for a runner twice on every pull-request event. Two of them also ran onpull_request_target, the last such triggers in this repository.Fix
Delete the three callers. Nothing else in
.github/workflows/changes, andci.ymlis untouched: theexempt-authorsvalue the linkage caller carried,dependabot[bot], already sits on thepr-contractstep, so Dependabot's bodies keep skipping the linkage check exactly as before.Three repository-owned sentences named a deleted file or the retired reusable as the enforcing gate and are now accurate:
conventions/review/code-quality.mdpointed at.github/workflows/pr-title.ymlas the wiring; it now names thepr-contractcomposite insideci-status.conventions/process/issue-tracker.mdsaid thepr-titlegate enforces Conventional Commits titles and that the sharedpr-issue-linkagegate mechanically enforces the body contract; the first now names the composite, and the second records the current posture, which is advisory (an upserted comment plus theneeds-issue-linkagelabel), not a red check.distribution/sync-manifest.ymldescribed thepr-body-contract-ruleentry as being for everypr-issue-linkagegate caller; those callers are what this pull request deletes.The ci-workflows reusables
semantic-pr.yml,do-not-merge-gate.ymlandpr-issue-linkage.ymlare untouched, as are thedo-not-mergeandneeds-issue-linkagelabels, which remain real.Verification
Pre-push, on the worktree at
origin/main36019f27defd2840032431d736089af7f6bac9f6:grep -rl "pull_request_target" .github/workflows/returns nothing.ls .github/workflows/ | grep -cE "^(pr-title|do-not-merge|pr-issue-linkage(-self)?)\.yml$"prints0.actionlint .github/workflows/*.ymlexits 0 with no output.zizmor --persona regular .github/workflows/reports63 findings (4 ignored, 58 suppressed): 1 informational, 0 low, 0 medium, 0 high. Theorigin/mainbaseline is70 findings (6 ignored, 63 suppressed): 1 informational, 0 low, 0 medium, 0 high. The one informational finding,use-trusted-publishing, is the same one on both trees; nothing new is reported.yq '.permissions' .github/workflows/ci.ymlprintscontents: read.npm run lint:runner-policy:Runner policy passed.npm run lint:concurrency-policy:Concurrency policy passed.npm run lint:dependabot-policy:Dependabot policy passed.npm run test:runner-policy: 288 pass, 0 fail.npm run test:concurrency-policy: 25 pass, 0 fail.npm run test:pr-convention-policy: 11 pass, 0 fail.npm run test:pr-convention-lockstep: 36 pass, 0 fail.git diff origin/main --statis six files: the three deletions and the three prose files.Nothing in
components/ordistribution/reads the deleted files.components/pr-convention-policy/lockstep-drift.mjsresolves every consumer over the GitHub contents API at that repository'smain, scansci.ymlfirst, and short-circuits on the composite indetectArtifactPin, so this repository's localpr-issue-linkage.ymlwas never read; itsREUSABLE_PATHconstant is dereferenced only for a repository that resolves tokind: "reusable".distribution/sync-manifest.ymllists none of the three files as a distributed path; the only mentions are comments.Live proof follows on this pull request: the deleted contexts must not appear on the head,
ci-statusmust be green, and itspr-contractstep log must show the title check and the linkage check running.Related
Refs melodic-software/github-iac#396
Refs melodic-software/github-iac#378