test(typos): cover all four inline ignore directive forms - #5
Merged
Conversation
The good fixture previously exercised only spellchecker:disable-line. Plant a real misspelling under each of the four blessed directives — disable-line, ignore-next-line, the comment block, and the HTML-comment block — so the good->exit-0 assertion conjunctively proves every form still suppresses. A break in any single directive surfaces its planted misspelling and fails the fixture. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
13 tasks
kyle-sexton
pushed a commit
that referenced
this pull request
Jul 23, 2026
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.3 to 3.1.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/fastify/fast-uri/releases">fast-uri's releases</a>.</em></p> <blockquote> <h2>v3.1.4</h2> <h2>⚠️ Security Release</h2> <p>Fix for <a href="https://github.com/fastify/fast-uri/security/advisories/GHSA-v2hh-gcrm-f6hx">https://github.com/fastify/fast-uri/security/advisories/GHSA-v2hh-gcrm-f6hx</a></p> <p><strong>Full Changelog</strong>: <a href="https://github.com/fastify/fast-uri/compare/v3.1.3...v3.1.4">https://github.com/fastify/fast-uri/compare/v3.1.3...v3.1.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/fastify/fast-uri/commit/6aeece669e4166b2446a89f17c07a3b15dfb7ed4"><code>6aeece6</code></a> Bumped v3.1.4</li> <li><a href="https://github.com/fastify/fast-uri/commit/2d50fbabc80e4d0884fe0f6a98fe118ce6faa353"><code>2d50fba</code></a> fix: reject literal backslash in URI authority</li> <li>See full diff in <a href="https://github.com/fastify/fast-uri/compare/v3.1.3...v3.1.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/melodic-software/standards/network/alerts). </details> ## Related - Resolves [Dependabot alert #5](https://github.com/melodic-software/standards/security/dependabot/5) (fast-uri host confusion, GHSA-v2hh-gcrm-f6hx) in `distribution`. No linked issue. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4. The good fixture previously exercised only
spellchecker:disable-line. This plants a real misspelling under each of the four blessed ignore directive forms, so agood -> exit 0result conjunctively proves every form still suppresses:spellchecker:disable-line(code comment)spellchecker:ignore-next-line(code comment)spellchecker:off/:on(code-comment block)<!-- spellchecker:off -->/<!-- spellchecker:on -->(HTML-comment block, invisible in rendered markdown)The planted words (
teh,recieve,seperate,occured,definately) are the same misspellings #4 confirmed typos flags in the bad fixture — a break in any single directive surfaces its word and fails the fixture.Local: typos good->0, self-lint->0, harness 5/5,
shellcheck -x+ editorconfig clean.