docs(topics): commit two uncommitted program Briefs for durability - #776
Conversation
The fresh-eyes-checkpoint-audit and underspecification topic contracts existed only as untracked files in one working tree — locked Briefs one git clean away from loss, repeatedly mislabeled as another session's residue. Commit them verbatim; program disposition (park/resume) is ruled separately on the tracking issue. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aec984627
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude finished @kyle-sexton's task in 2m 13s —— View job PR Review
Purpose: Durability commit for two topic Briefs that existed only as untracked working-tree files. No content was changed — the files are committed verbatim. The PR description is accurate; disposition of the programs is deferred. The durability rationale is sound. The files contain valuable locked contracts and design decisions that would be lost to Finding 1 —
|
… count The rescued underspecification contract's acceptance criteria had all shipped before the commit — banner records completion. The fresh-eyes execution checklist said four re-anchor skills where its own Phase 2 row requires the shared spoke plus all eleven; corrected to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 10s —— View job PR Review
The latest commit ( Finding 1 — underspecification Brief staleness (resolved) A COMPLETED banner was prepended at the top of the file: The stale Goal section body is intentionally left in place under the banner as historical record, which is appropriate for a durability commit. A future session picking up this topic will see COMPLETED immediately and stop. No issues. Finding 2 — re-anchor skill count contradiction (resolved) The to: The inline parenthetical explaining the prior "four" is useful for anyone reading git history and tracking down the discrepancy. The corrected bullet now matches the Phase 2 table and the actual skill count in OverallBoth prior findings are resolved. The PR achieves its stated purpose — durability commit for two locked contracts — and the follow-up corrections land in this same branch before merge. No remaining issues. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56351c51e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The deferred-trigger note claimed the repo-fleet-hygiene audit stands in as the recheck mechanism, but that audit inventories git/GitHub state only and never invokes the skill gate — the WARN-clean invariant is unmonitored until the trigger fires. Recorded as a rescue-time correction; the resuming implementer picks the mechanism. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Claude finished @kyle-sexton's task in 1m 9s —— View job PR Review
The latest commit ( Finding 3 — fleet recheck claim (resolved) The "Open questions" note at line 325 previously ended with:
Commit
The Codex reviewer asked for either CI wiring or an honest description of what the actual checker is. The correction takes the second path: it explicitly states no interim mechanism exists, correctly characterises All findings from this review thread resolved:
No remaining issues. The PR achieves its stated purpose — durability commit for two locked contracts — with all three review-round corrections landing on the same branch before merge. |
…e (check 21) (#1096) ## Summary Phase 1 of the fresh-eyes program (#304), per `docs/topics/fresh-eyes-checkpoint-audit/PLAN.md`: the delegation-mechanics doctrine and its deterministic conformance gate land together, so every Wave-2 retrofit PR that follows conforms to a merged spec. - **`docs/PLUGIN-PHILOSOPHY.md`** — new `## Delegation mechanics` section beside the existing fresh-eyes section: dispatch ladder (generic fresh-context subagent with rich inline instructions = default; named agent behind the earned bar; cross-vendor advisor on top, always presence-gated with the generic fallback), inline-template conventions (fresh-context wording, artifact-not-story, degrade-when-absent), named-agent bar, model-tier ladder with a dated tier-to-model mapping and recheck trigger, tool-cage framing (Bash-holding allowlists are not read-only), and the two declared patterns with the `skill-quality` plugin as spec owner (convention-registry row added). Every load-bearing claim cites its official page, fetched and verified 2026-07-22 (six dated citations). Existing fresh-eyes section reconciled: "a named subagent removes it" → fresh-context (non-fork) subagent, generic or named. - **`check-skill.sh` check 21 — fresh-eyes declaration conformance** — implements the semantics table in `docs/topics/fresh-eyes-checkpoint-audit/design/design-resolution.md` verbatim: FAIL on malformed/unknown-class/reason-less `fresh-eyes-exempt` directives; WARN-only judgment-language heuristic (curated POSIX ERE, seeded from the audited skills' phrasing); stale-directive WARN (advisory); per-file line proximity (`FRESH_EYES_PROXIMITY_LINES`, tunable constant); fence- and inline-code-span-aware detectors (self-reference guard); CRLF-tolerant; scan surface = SKILL.md + skill-internal spoke dirs, `vendor/` and `evals/` excluded. - **Consumer-facing spec** — `plugins/skill-quality/skills/check/reference/fresh-eyes-declarations.md` carries the mechanical contract (grammar, classes, semantics table, curation policy); check-21 messages point at it so third-party authors can read the rule without this repo's doctrine. - **Test fixtures** — 9 new cases (29–37): FAIL malformed / unknown class / missing reason; WARN undeclared judgment language / stale directive; PASS delegation prose (both spellings), valid exemption, fenced literals (self-reference guard), no judgment language. - **Packaging** — plugin 0.9.0 → 0.10.0, CHANGELOG entry, SKILL.md + plugin.json + root README descriptions "twenty" → "twenty-one"; also fixes pre-existing stale counts (plugin README still said "eighteen"/"seventeen" after checks 19–20 shipped; the checks list gained the missing injection-portability row). ## Plan deltas (re-verified against current main per the plan's own freshness mandate) - Check number is **21**, not 18/19 — two more checks shipped since the plan was authored. - The plan's item to correct `docs/MIGRATION-PLAYBOOK.md:984` no longer applies: the current "seventeen" hit (line ~1115) is a dated 2026-07-13 decision record describing what the plugin shipped THEN — historical, true at its date, left intact. - The topic slice already sits on main via #776, so this PR does not re-carry it. - Fresh-docs re-fetch (plan work item 1) completed 2026-07-22 by a fresh-context agent: all seven doctrine claims verified against current official pages; no Brief constraint reopened. Notable current facts cited in the doctrine: frontmatter `model` defaults to `inherit`; `CLAUDE_CODE_SUBAGENT_MODEL` (model-config page) overrides both the per-invocation param and frontmatter; no per-plugin model seam in `userConfig`. ## Verification - `shellcheck` clean on `check-skill.sh`; `bash plugins/skill-quality/scripts/check-skill.test.sh` exits 0 — 56 assertions including 10 new check-21 fixtures (fixture demo of the FAIL half: the malformed-directive fixture exits 1 naming the defect). - `npx markdownlint-cli2` clean on every changed markdown file. - Independent fresh-context review before commit: 4 IMPORTANT findings, all fixed and empirically re-verified (consumer-facing spec path in messages; word-boundary guards on the judgment regex — "upgrade your own"/"underscore its own" no longer hit; CommonMark fence-matching so nested `~~~`/``` ``` `` examples cannot desync the scanner; a fixture for the contradictory-declaration branch). - Fleet evidence (method delta from the plan, recorded in the memory slice): checks 1–20 are untouched and the suite proves no regression there, so the full-gate baseline diff is vacuous — the only possible gainers are check-21 emissions. The shipped check-21 scanner (extracted verbatim at runtime) ran over all 173 skills: **0 FAIL, 56 WARN sites in 24 skills**, every site triaged and dispositioned (`.work/fresh-eyes-checkpoint-audit/baselines/ check21-warn-triage-20260722.md`): expected tranche-1/2 gainers ride Phases 2/4; the rest are hand-verified meta-text/quote/narrative hits; zero mechanical false hits, no regex change warranted. A clean full-gate pre-change baseline at the merge-base is retained alongside. - Doctrine section: ≥4 dated citations (actual: 6); registry row present. ## Related - Program: #304 — this is its Phase 1; the program issue stays open for Phases 2–4 (retrofits, corrections, tranche-2 filing). - No linked issue: this PR deliberately closes no issue (closing #304 here would prematurely close the multi-phase program). --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 participant
No linked issue — durability commit for two existing contracts; program disposition is ruled separately.
docs/topics/fresh-eyes-checkpoint-audit/PLAN.md(Brief locked 2026-07-19 for #304, Plan never filled) anddocs/topics/underspecification/PLAN.mdexisted only as untracked working-tree files — a locked contract onegit clean -fdxfrom loss, and repeatedly dismissed in handoffs as "untracked dirt NOT ours." Committed verbatim, no content changes.Related
🤖 Generated with Claude Code