feat(disk-hygiene): kill-switch probe reports interpreter and --data-root (#4215) - #4726
Merged
Merged
Conversation
… and --data-root (#4215) The probe's JSON gains hook_python and data_root, computed by the guard's own launch_disclosure (the helpers its denial guidance uses) against the probe's install root. The clean skill takes both from the probe instead of submitting a scan with bare python to provoke a denial. A parity test runs the probe beside a belt denial and compares the values. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Contributor
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
This was referenced Sep 28, 2026
kyle-sexton
added a commit
that referenced
this pull request
Sep 30, 2026
…guard values (#5508) Closes #4215 ## Summary The owner decision on #4215 (2026-09-29) chose option A: keep the UserPromptExpansion hook that injects `hook_python` and `data_root`, and accept the one denied probe in the no-hook path. This PR applies that decision to the skill wording. ## Fix - `plugins/disk-hygiene/skills/clean/SKILL.md`: one primary source (the `disk-hygiene guard values` note) and one fallback (bare-python probe denied once, then the probe's `data_root` field). - `plugins/disk-hygiene/skills/clean/reference/safety-model.md`: records that the hook is the chosen delivery path and the denied probe in the no-hook path is an accepted residual. - disk-hygiene 0.28.19 -> 0.28.20 with a CHANGELOG entry. ## Verification - `scripts/check-changelog-parity.sh --check --check-order`: passes. - `scripts/validate-plugins.sh`: all manifests and the catalog validated. - `python3 -m unittest discover -s skills/clean/scripts -p 'test_*.py'` in `plugins/disk-hygiene`: 546 tests OK. ## Related #4632 (hook), #4726 (probe fields), #5336 (untouched by this change). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4215
Kill-switch probe prints
hook_pythonanddata_rootsocleanno longer needs a denied scan to learn them. Skill runs the probe first.Test plan