feat(disk-hygiene): hand clean the guard interpreter and data root up front (#4215) - #4632
Merged
cursor[bot] merged 2 commits intoSep 27, 2026
Merged
Conversation
…and data root up front A UserPromptExpansion hook runs engine_context.py through the same launcher and --plugin-root argument as the skill guard and injects the guard's absolute Python and authorized --data-root as context, so a run no longer opens with a deliberately denied scan. The denial route stays as the fallback. Closes #4215 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Contributor
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
Shebang'd Python entrypoints and their test drivers must be 100755 so the exec-bit hygiene gate matches the rest of plugins/disk-hygiene/skills/*/scripts. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
cursor
Bot
deleted the
cursor/4215-disk-hygiene-expansion-context-37e9
branch
September 27, 2026 20:47
This was referenced Sep 27, 2026
kyle-sexton
added a commit
that referenced
this pull request
Sep 30, 2026
…guard values (#5508) Closes #4215 ## Summary The owner decision on #4215 (2026-09-29) chose option A: keep the UserPromptExpansion hook that injects `hook_python` and `data_root`, and accept the one denied probe in the no-hook path. This PR applies that decision to the skill wording. ## Fix - `plugins/disk-hygiene/skills/clean/SKILL.md`: one primary source (the `disk-hygiene guard values` note) and one fallback (bare-python probe denied once, then the probe's `data_root` field). - `plugins/disk-hygiene/skills/clean/reference/safety-model.md`: records that the hook is the chosen delivery path and the denied probe in the no-hook path is an accepted residual. - disk-hygiene 0.28.19 -> 0.28.20 with a CHANGELOG entry. ## Verification - `scripts/check-changelog-parity.sh --check --check-order`: passes. - `scripts/validate-plugins.sh`: all manifests and the catalog validated. - `python3 -m unittest discover -s skills/clean/scripts -p 'test_*.py'` in `plugins/disk-hygiene`: 546 tests OK. ## Related #4632 (hook), #4726 (probe fields), #5336 (untouched by this change). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hand
/disk-hygiene:cleanthe guard interpreter and data root up front; mark newengine_contextPython scripts100755for the exec-bit gate.Test plan
git ls-files -sshows100755on shebang'd scriptsRefs #4215