fix(implementation): define wave unit; one writer per worktree under worker authority (#4262) - #4698
Merged
Merged
Conversation
… per worktree under both commit authorities (#4262) A wave is a batch of one phase's worker rows, each an independent brief with its own disjoint fence; --wave-cap bounds rows in flight. The single-committer rule #4511 shipped bound only under orchestrator authority; under the default worker authority rows sharing a worktree now run one at a time, and concurrent rows in a shared worktree need orchestrator. Updates the wave-cap eval and adds a worker-authority shared-worktree eval. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…bounds (#4262) The userConfig description, README, and work skill said the cap bounds "concurrent dispatch waves"; it bounds the worker rows of one phase implement-dispatch runs at once, one wave. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
# Conflicts: # plugins/implementation/.claude-plugin/plugin.json # plugins/implementation/CHANGELOG.md # plugins/implementation/skills/implement-dispatch/SKILL.md Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Contributor
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4262
Summary
Defines a wave as one phase’s worker-row batch. One git writer per worktree binds under both commit authorities (
worker→ serialize shared worktree; concurrent shared worktree needsorchestrator). Keeps #4511 orchestrator concurrency. New/updated evals 7 and 9.Versions:
implementation→ 0.18.2;work-itemswording bump (may collide with stacked #4688–#4690 — serialize on merge).Sources
Test plan
Notes
Merge after work-items stack #4688/#4689/#4690 if those land first, or renumber work-items here.