Skip to content

docs(work-items): require umbrella-side membership comment in fold sequence - #2492

Closed
kyle-sexton wants to merge 3 commits into
mainfrom
cursor/umbrella-fold-atomic-comments-63e1
Closed

docs(work-items): require umbrella-side membership comment in fold sequence#2492
kyle-sexton wants to merge 3 commits into
mainfrom
cursor/umbrella-fold-atomic-comments-63e1

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Closes #633

Documents the atomic fold sequence (item comment, umbrella comment, blocked-by edge, strip raw marker) in issue-conventions.md.

Related

None.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d50afccf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/work-items/reference/issue-conventions.md
@kyle-sexton
kyle-sexton force-pushed the cursor/umbrella-fold-atomic-comments-63e1 branch from 9d50afc to e79da22 Compare August 12, 2026 17:13
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job to retry the review; a new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

@cursor
cursor Bot force-pushed the cursor/umbrella-fold-atomic-comments-63e1 branch from 71d6a06 to 0621927 Compare August 12, 2026 17:34
cursoragent and others added 3 commits August 12, 2026 17:48
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/umbrella-fold-atomic-comments-63e1 branch from 0621927 to d4ed863 Compare August 12, 2026 17:48
@kyle-sexton

Copy link
Copy Markdown
Contributor Author

Closing as duplicate: umbrella-side membership comment requirement is already on main (fold sequence docs landed via #2488 / related merges). Remaining diff is only a conflicting 0.35.9 changelog bump.

@github-actions

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

work-items:triage: umbrella-fold routing misses the umbrella-side membership comment (item-side only, 3x this session)

2 participants