Skip to content

fix(work-items): harden triage intake against priority-axis stacking and blocked-by relabel races - #2488

Merged
kyle-sexton merged 3 commits into
mainfrom
cursor/triage-intake-hygiene-63e1
Aug 12, 2026
Merged

fix(work-items): harden triage intake against priority-axis stacking and blocked-by relabel races#2488
kyle-sexton merged 3 commits into
mainfrom
cursor/triage-intake-hygiene-63e1

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Closes #632
Closes #646

Summary

  • Treat priority: as single-valued: strip existing priority: labels before applying the assessed priority in step 5.
  • Skip attention-view rows that already have a blocked-by edge plus a prior triage comment (defensive guard against cross-lane raw-marker re-labels).

Related

None.

@cursor
cursor Bot force-pushed the cursor/triage-intake-hygiene-63e1 branch from 6036093 to 917b304 Compare August 12, 2026 17:02
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor
cursor Bot force-pushed the cursor/triage-intake-hygiene-63e1 branch from 917b304 to b156d40 Compare August 12, 2026 17:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 917b304a4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/work-items/reference/issue-conventions.md
Comment thread plugins/work-items/reference/issue-conventions.md
Comment thread plugins/work-items/reference/issue-conventions.md
@kyle-sexton
kyle-sexton force-pushed the cursor/triage-intake-hygiene-63e1 branch from b156d40 to 7acada7 Compare August 12, 2026 17:13
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 35s —— View job


Security Review

  • Gather context (PR diff, changed files)
  • Review plugins/work-items/reference/issue-conventions.md
  • Review plugins/work-items/skills/triage/SKILL.md
  • Post findings

No security issues found.

This PR touches only two Markdown reference/skill files that document conventions and instructions consumed by an AI triage workflow — no executable code, scripts, or GitHub Actions workflow files are modified:

  • plugins/work-items/reference/issue-conventions.md (+5/-0): adds prose describing an atomic umbrella-folding sequence (comment → comment → blocked-by edge → strip raw marker).
  • plugins/work-items/skills/triage/SKILL.md (+2/-2): adds a defensive-skip rule to the attention-view bucketing instructions, and a rule to strip existing priority: labels before applying an assessed one.

I checked for the categories in scope — injection surfaces (command/SQL/path/template), unsafe handling of tokens/secrets/credentials, dangerous GitHub Actions patterns (pull_request_target/workflow_run, script injection via the github context, permission widening), and supply-chain/pin risk. None apply: no shell commands, workflow YAML, or code are introduced or altered by this diff. The gh label list --search 'priority:' reference is pre-existing and unchanged.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job to retry the review; a new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

cursoragent and others added 3 commits August 12, 2026 17:34
…and blocked-by relabel races

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/triage-intake-hygiene-63e1 branch from f39ea30 to 70c38e0 Compare August 12, 2026 17:34
@kyle-sexton
kyle-sexton merged commit 8804199 into main Aug 12, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/triage-intake-hygiene-63e1 branch August 12, 2026 17:44
@github-actions

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants