Skip to content

ci(review): route Claude review through fleet #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyle-sexton wants to merge 1 commit into from
Closed

ci(review): route Claude review through fleet #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/runner-policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
"reason": "hosted-control-plane",
"justification": "The required CI gateway remains independent of selector and fleet health so route failures cannot become successful skipped checks."
},
".github/workflows/claude-review.yml#review": {
"reason": "privileged-control-plane",
"justification": "Claude review mints an OIDC credential and writes pull-request comments, so it remains isolated on GitHub-hosted compute."
},
".github/workflows/link-check.yml#link-check": {
"reason": "privileged-control-plane",
"justification": "The scheduled link checker can create or update repository issues and therefore remains on GitHub-hosted compute."
Expand Down
22 changes: 18 additions & 4 deletions .github/workflows/claude-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,29 @@ permissions:
contents: read

jobs:
select-runner:
name: Select runner
uses: melodic-software/ci-workflows/.github/workflows/select-runner.yml@3415de3ff2fafee40e4d087eb6073d2f6952b595 # 3415de3 2026-07-13
with:
policy: ${{ vars.CI_RUNNER_POLICY }}
self-hosted-label: ${{ vars.CI_SELF_HOSTED_LABEL }}
hosted-runner: ${{ vars.CI_HOSTED_RUNNER }}
scope: ${{ vars.CI_RUNNER_SCOPE }}
managed-runner-prefix: ${{ vars.CI_MANAGED_RUNNER_PREFIX }}
observer-client-id: ${{ vars.CI_RUNNER_OBSERVER_CLIENT_ID }}
secrets:
observer-private-key: ${{ secrets.CI_RUNNER_OBSERVER_PRIVATE_KEY }}

review:
# Privileged review remains hosted by policy. Skip it while strict local-only
# emergency routing is active; prefer-self-hosted restores the hosted lane.
if: ${{ vars.CI_RUNNER_POLICY != 'self-hosted-only' }}
needs: select-runner
if: ${{ !cancelled() && needs.select-runner.result == 'success' }}
permissions:
contents: read # checkout + read the diff
pull-requests: write # post review + track_progress tracking comment
id-token: write # OIDC — mints the Claude GitHub App token
uses: melodic-software/ci-workflows/.github/workflows/claude-review.yml@99ac2f8c5b09dbb785d4eaf18465cbd96c30290c # 99ac2f8 2026-07-11
uses: melodic-software/ci-workflows/.github/workflows/claude-review.yml@4dbb0dfcc1fcbaf30e1a5573bf776af54e4e7e1a # 4dbb0df 2026-07-15
with:
runner: ${{ needs.select-runner.outputs.runner || 'ubuntu-24.04' }}
# Pass only the one named secret (least privilege) rather than `secrets:
# inherit`, which would forward every parent secret to the called workflow.
secrets:
Expand Down
Loading