Skip to content

ci(review): route Claude review through fleet - #211

Closed
kyle-sexton wants to merge 1 commit into
mainfrom
agent/issue-78-claude-review-fleet
Closed

ci(review): route Claude review through fleet#211
kyle-sexton wants to merge 1 commit into
mainfrom
agent/issue-78-claude-review-fleet

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Summary

  • route the Claude review reusable caller through the repository's governed runner selector
  • pin the fleet-capable reusable workflow and pass the selector result with the established hosted fallback
  • remove the now-obsolete hosted-runner exception

This advances melodic-software/github-iac#78.

Dependency

Depends on melodic-software/standards#140 plus the generated runner-policy sync. Current old-policy CI may fail or queue until then. This is intentionally a dependency-blocked draft.

No managed files were edited; this changes only the repository-local caller and repository policy exception.

Validation

@kyle-sexton

Copy link
Copy Markdown
Contributor Author

Closing for now rather than leaving this parked indefinitely.

This PR's routing change conflicts with main's current claude-review.yml pin (df54d0e, merged via #222), which fixed a real bug — the review job was silently reporting green while actually failing for 27+ hours. Merging this PR's pin (4dbb0df) would revert that fix.

standards' runner-policy only has an approved contract for 4dbb0df + routing, not df54d0e + routing, so there's no way to land both the fix and the routing feature together today without a standards policy update.

Reopen/readdress once standards adds a policy entry covering df54d0e (or later) with the runner-routing input.

kyle-sexton added a commit that referenced this pull request Jul 17, 2026
…ier (#230)

## What

- Add a `select-review` job resolving `${{
vars.CI_REVIEW_SELF_HOSTED_LABEL }}` through the governed selector
(pinned `select-runner@cdc5917c`).
- Route the `review` job's runner from the selector output to the fleet
claude-review reusable (pinned `claude-review@4dbb0dfc`), permissions
exactly per the reviewed caller-perms waiver.
- Retire the `CI_RUNNER_POLICY != 'self-hosted-only'` skip guard — under
strict routing it was silently skipping every review in this repo; fleet
routing restores review coverage.
- Drop the `privileged-control-plane` hosted exception for
`claude-review.yml#review`.

## Why

Campaign A of the zero-hosted directive (epic
melodic-software/github-iac#78): automated review moves to the dedicated
capped review tier. Shape matches standards' runner-policy E2E fixture;
`runner-policy.mjs --root .` passes locally with zero findings.

Supersedes the closed draft #211.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01K3QehVwmWzkBLpKokNCkkt

---------

Co-authored-by: Claude Fable 5 (1M context) <noreply@anthropic.com>
@kyle-sexton
kyle-sexton deleted the agent/issue-78-claude-review-fleet branch July 18, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant