Skip to content

docs(source-control): name config-root.sh by its lib path in the ready reference #10720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 2 commits into from
Oct 28, 2026
Merged

docs(source-control): name config-root.sh by its lib path in the ready reference #10720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd01d4
docs(source-control): name config-root.sh by its lib path in the read…
kyle-sexton Oct 28, 2026
cc7001b
Merge branch 'main' into docs/ready-config-root-path
kyle-sexton Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/source-control/docs-ready-config-root-path-5b7e2d13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Fixed

- The `/source-control:pull-request` ready and create references name `config-root.sh` by its `<plugin-root>/lib/` path, so an agent no longer runs a nonexistent `scripts/config-root.sh` (exit 127).
2 changes: 1 addition & 1 deletion plugins/source-control/skills/pull-request/reference/create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ levels are in [../../../reference/config-resolution.md](../../../reference/confi
requested early look`, `Draft: multi-session container`, or `Draft: <reason>` for the flag.
That line tells unattended flippers the draft is a person's choice; only a person removes it
or flips the PR.
1. **Repository level.** When §2.4.1's `config-root.sh classify` printed `repo`, read
1. **Repository level.** When §2.4.1's `<plugin-root>/lib/config-root.sh classify` printed `repo`, read
`docs/conventions/source-control.yaml` at the PR's base branch in the base repository, never
from the working tree or the branch being opened, the same way the review-bot rubric is read
([config-resolution.md](../../../reference/config-resolution.md#review-bot-triage-rubric-docsconventionssource-controlmd);
Expand Down
2 changes: 1 addition & 1 deletion plugins/source-control/skills/pull-request/reference/ready-for-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ such as a stacked layer, is a branch the PR's author may have pushed without rev
there could switch off the reviews of the author's own PR. The read goes through
`scripts/read-pre-ready.sh`, given the base and the default branch. It prints a `source` line
(`default`, `config`, or `fail-closed` with a reason) and one `<step> enabled|disabled` line per
step. When `config-root.sh classify` does not print `repo`, skip the read: every step runs.
step. When `<plugin-root>/lib/config-root.sh classify` does not print `repo`, skip the read: every step runs.

Every step runs when the file or the key is missing, and when the reader fails closed:
`base <name> is not the default branch <default>`, a base or default branch that could not be
Expand Down
Loading