Skip to content

docs(source-control): name config-root.sh by its lib path in the ready reference - #10720

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/ready-config-root-path
Oct 28, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/ready-config-root-path

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: wrong script path found while running ready on #10701

Why

The ready reference says "When config-root.sh classify does not print repo" with no path. An agent following it ran <plugin-root>/scripts/config-root.sh and got exit 127; the script is <plugin-root>/lib/config-root.sh.

What changed

  • ready-for-review.md and create.md name the script as <plugin-root>/lib/config-root.sh classify.
  • A patch changelog fragment for source-control.

Scope

In: the two bare mentions in skill reference markdown (the other config-root.sh mentions already carry lib/). Out: any script or behavior change.

Verification

  • scripts/validate-plugins.sh --only "source-control" printed "All plugin manifests and the catalog validated."
  • scripts/check-affected.sh reported 13 passed, 2 skipped.

Left out: nothing

🤖 Generated with Claude Code

…y reference

The ready and create references wrote a bare `config-root.sh classify`; an
agent ran `<plugin-root>/scripts/config-root.sh` (exit 127). The script is at
`<plugin-root>/lib/config-root.sh`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR body contract — issue linkage

This PR body does not yet satisfy the issue-linkage contract:

  • Missing a "## Summary" section. Describe what this PR changes and why, in a sentence or two.
  • Missing a "## Fix" section. State the concrete change and how it addresses the problem.
  • Missing a "## Related" section. List related PRs, ADRs, or decision-log entries this PR does not close.

Edit the body and this comment updates itself on the next run.

@kyle-sexton
kyle-sexton marked this pull request as ready for review October 28, 2026 19:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T19:10:52.641754Z cc7001b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed cc7001be5abd2596b25e8aa0446ddd3e38f7169a: 0 finding(s), 0 as inline comments.

No findings. This is a docs-only change, and I reviewed all three changed files.

  • ready-for-review.md and create.md now write <plugin-root>/lib/config-root.sh classify. I checked that plugins/source-control/lib/config-root.sh exists and that the other config-root.sh mentions under plugins/source-control already point to lib/, so the path is right and consistent.
  • The .changes/source-control/ fragment uses bump: patch with a ### Fixed entry, which fits a wording fix in skill reference docs.
  • There is no closing issue, so no acceptance criteria apply.
  • No manifest files changed, so the manifest checks don't apply.
  • No trusted-path files changed.
  • Nothing in the change spends money, so no hold applies.

The PR's validation claims (validate-plugins.sh and check-affected.sh results) are the author's and I did not run them.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed cc7001be5abd2596b25e8aa0446ddd3e38f7169a: 0 finding(s), 0 as inline comments.

No security issues found.

The change is documentation only. It adds a changelog fragment and edits two skill reference files, create.md and ready-for-review.md. Each edit names config-root.sh by its <plugin-root>/lib/ path. I confirmed that plugins/source-control/lib/config-root.sh exists, so the corrected path is accurate.

  • Instruction surface: No rule is deleted, narrowed or softened. The gating conditions in both passages are unchanged: "when classify printed repo", the base-branch read of the config, and the fail-closed behavior. I did not consult the instruction exception register, because nothing was removed from any standing instruction.
  • Manifests: The diff touches no plugin.json or marketplace.json, so there are no manifest lines to report.
  • Trusted paths: None of the three changed files matches a trusted-path glob.
  • PR context: The description contains no embedded instructions.
  • Cost: The change spends nothing.

critical-findings: 0

@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 164953b Oct 28, 2026
75 checks passed
@kyle-sexton
kyle-sexton deleted the docs/ready-config-root-path branch October 28, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant