-
Notifications
You must be signed in to change notification settings - Fork 1
fix: correct audit findings and add offline link/anchor dogfood lane #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # lychee ruleset — repo-agnostic link-checking config. | ||
| # The offline CI lane runs with --offline (external URLs skipped); the online | ||
| # advisory lane reuses this file with the network enabled. | ||
| # Ref: https://github.com/lycheeverse/lychee/blob/master/lychee.example.toml | ||
|
|
||
| # Verify #fragment/anchor targets resolve, not just the file path ("full" | ||
| # checks both anchor and text fragments). | ||
| include_fragments = "full" | ||
|
|
||
| # Build/dependency trees — not authored content. Values are regex (single-quoted | ||
| # TOML literals, so backslashes are not double-escaped). | ||
| exclude_path = [ | ||
| 'node_modules', | ||
| '\.venv', | ||
| '/bin/', | ||
| '/obj/', | ||
| ] | ||
|
|
||
| # URL excludes for the online lane (the offline lane skips URLs entirely): | ||
| # auth-walled hosts that block automated checkers, loopback, and placeholders. | ||
| exclude = [ | ||
| '^https?://(www\.)?x\.com/', | ||
| '^https?://twitter\.com/', | ||
| '^https?://(www\.)?linkedin\.com/', | ||
| '^https?://bsky\.app/', | ||
| '^https?://localhost', | ||
| '^https?://127\.0\.0\.1', | ||
| '^https?://example\.(com|org)', | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the scheduled
link-checkworkflow runs with its defaults, it reuses this new config via--config modules/lychee/lychee.toml, but the pinnedlycheeverse/lychee-action@8646...is v2.8.0 and its action metadata defaults tolycheeVersion: v0.23.0; I checked the v0.23.0 example config, whereinclude_fragmentsis still boolean (include_fragments = true), while the"full"value is documented for current v0.24.x. As a result the online reusable workflow will fail parsing the config instead of checking links unless you either pin the action to a lychee 0.24+ binary or keep this setting compatible with v0.23.Useful? React with 👍 / 👎.