Skip to content

fix: correct audit findings and add offline link/anchor dogfood lane - #6

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/audit-corrections
Jun 22, 2026
Merged

fix: correct audit findings and add offline link/anchor dogfood lane#6
kyle-sexton merged 1 commit into
mainfrom
fix/audit-corrections

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Per-file audit of the repo, validated against authoritative sources (tool repos at pinned tags, Microsoft Learn, git-scm; release checksums and action SHA→tag pins verified empirically).

Behavior fixes

  • link-check: create-issue-from-file does not dedup by title — resolve the open tracking issue and pass issue-number so a single rolling issue is updated instead of filing a duplicate on every scheduled failure. Report path aligned to the documented lychee/out.md.
  • link-check: replaced the unsourced "1,000 req/hour" claim with accurate token-auth wording.

Accuracy / comments

  • lychee-offline: clarified that #anchor checking is ruleset-driven (include_fragments, which the standard lychee.toml sets to full); the CLI default is off and is intentionally not overridden.
  • Invoke-Pssa.ps1: corrected docstring — race is issue #1708 (not Linux-specific); 1.25.0 resolves #2106/#2107 (not a "7.4.14 NRE").

Maintenance / CI

  • dependabot: documented that embedded tool versions (markdownlint-cli2, Node, PSScriptAnalyzer, ShellCheck, lychee) are outside Dependabot and tracked manually; added groups, open-pull-requests-limit, commit-message.
  • ci: added an offline lychee lane into the ci-status gateway (dogfoods the action) and vendored modules/lychee/lychee.toml.

Synced from standards (upstream source of truth)

.editorconfig, .gitattributes, modules/markdown/.markdownlint-cli2.jsonc, modules/powershell/PSScriptAnalyzerSettings.psd1: corrected inaccurate comments (false PowerShell-repo eol claim, "cmd.exe requires CRLF" overstatement, dangling editorconfig cross-ref, MD060 comment), removed redundant MD055, enabled MD040, documented PSUseCompatibleSyntax major-version matching.

Validation

actionlint clean; YAML parses; markdownlint clean on real docs (MD040 on); standards fixture-test semantics preserved; PSScriptAnalyzer clean; PSD1 loads.

🤖 Generated with Claude Code

- link-check: resolve the open tracking issue and pass issue-number so a
  single rolling issue is updated instead of filing a duplicate each run
- link-check: accurate GITHUB_TOKEN rationale; align report path to lychee/out.md
- lychee-offline: clarify that #anchor checking is ruleset-driven (include_fragments)
- powershell: correct Invoke-Pssa docstring (race #1708; 1.25.0 fixes #2106/#2107)
- dependabot: document manually-tracked tool versions; add groups, PR limit, prefix
- ci: add offline lychee lane to the ci-status gateway (dogfood) + vendor lychee.toml
- sync corrected standards configs (.editorconfig, .gitattributes, markdown, pssa)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kyle-sexton
kyle-sexton merged commit cc9f40e into main Jun 22, 2026
9 checks passed
@kyle-sexton
kyle-sexton deleted the fix/audit-corrections branch June 22, 2026 21:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2dc5972e77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


# Verify #fragment/anchor targets resolve, not just the file path ("full"
# checks both anchor and text fragments).
include_fragments = "full"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a v0.23-compatible fragment setting

When the scheduled link-check workflow runs with its defaults, it reuses this new config via --config modules/lychee/lychee.toml, but the pinned lycheeverse/lychee-action@8646... is v2.8.0 and its action metadata defaults to lycheeVersion: v0.23.0; I checked the v0.23.0 example config, where include_fragments is still boolean (include_fragments = true), while the "full" value is documented for current v0.24.x. As a result the online reusable workflow will fail parsing the config instead of checking links unless you either pin the action to a lychee 0.24+ binary or keep this setting compatible with v0.23.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant