Skip to content

fix: serve mctl-web on port 80 (v3 deploy outage fix) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mashkovd merged 1 commit into from
May 30, 2026
Merged

fix: serve mctl-web on port 80 (v3 deploy outage fix) #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ RUN npm run generate
FROM nginx:alpine
COPY nginx.conf /etc/nginx/conf.d/default.conf
COPY --from=builder /app/.output/public/ /usr/share/nginx/html/
EXPOSE 8080
HEALTHCHECK --interval=30s --timeout=5s CMD wget -q --spider http://localhost:8080/healthz || exit 1
EXPOSE 80

@chatgpt-codex-connector chatgpt-codex-connector Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep PR preview services on the new container port

This changes the image contract to port 80, but the PR preview workflow still writes service.port: 8080 into the generated gitops values (.github/workflows/preview-create.yml lines 65-72). For previews created by that workflow, the Service/probes will continue targeting 8080 while this nginx image now only listens on 80, so new PR preview deployments can become unhealthy or unreachable even though production is fixed.

Useful? React with 👍 / 👎.

HEALTHCHECK --interval=30s --timeout=5s CMD wget -q --spider http://localhost/healthz || exit 1
CMD ["nginx", "-g", "daemon off;"]
2 changes: 1 addition & 1 deletion nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
server {
listen 8080;
listen 80;
server_name _;
root /usr/share/nginx/html;
index 200.html index.html;
Expand Down
Loading