Repository navigation
fix: serve mctl-web on port 80 (v3 deploy outage fix) - #20
Conversation
v3 (6.2.0) switched nginx/Dockerfile to port 8080, but the base-service k8s Service + probes target port 80 — so the 6.2.0 pod never went Ready and mctl.ai 503'd until rollback to 6.1.0. Revert listen/EXPOSE/health- check to 80 (the working 6.1.0 contract) so v3 can deploy.
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
|
Preview: https://mctl-web-pr-20.mctl.ai Deploying — ArgoCD will be Healthy in ~60s after this comment. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e7c2aeeda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| COPY --from=builder /app/.output/public/ /usr/share/nginx/html/ | ||
| EXPOSE 8080 | ||
| HEALTHCHECK --interval=30s --timeout=5s CMD wget -q --spider http://localhost:8080/healthz || exit 1 | ||
| EXPOSE 80 |
There was a problem hiding this comment.
This changes the image contract to port 80, but the PR preview workflow still writes service.port: 8080 into the generated gitops values (.github/workflows/preview-create.yml lines 65-72). For previews created by that workflow, the Service/probes will continue targeting 8080 while this nginx image now only listens on 80, so new PR preview deployments can become unhealthy or unreachable even though production is fixed.
Useful? React with 👍 / 👎.
Summary
v3 (6.2.0) changed nginx
listen/ DockerfileEXPOSE+ healthcheck to 8080, but the platformbase-serviceService and readiness/liveness probes target port 80. The 6.2.0 pod's probe never passed → no healthy endpoint → mctl.ai 503. Rolled back to 6.1.0 (port 80) to restore service.This reverts the port to 80 (matching the working 6.1.0 contract) so the v3 redesign can deploy. nginx keeps its
/healthz+/readyzendpoints.Verification
npm run build✓🤖 Generated with Claude Code