Repository navigation
feat(agents): resume the incident responder - #870
Merged
Merged
Conversation
Suspended 2026-07-29 alongside the implementer. Both blockers are now gone, and both were checked against Vault and the cluster rather than taken from a changelog. The reason written in this file was an unseeded claude-code-oauth-token-2: with no second account to retry on, the fallback step failed the whole run rather than masking it. Vault secret/platform/mctl-agents now carries that field beside claude-code-oauth-token, both 108 chars. The reason people actually cite is different — diagnosed tickets sitting in analyzing forever — and it is fixed by the escalated status in mctl-agent 1.16.0, released today and live on admins-mctl-agent-base-service. Worth noting the two are separate blockers that happened to clear together; resuming because the remembered one is fixed, while the recorded one still held, would have reintroduced exactly the failure this suspension existed to prevent. The sibling CronWorkflows stay suspended, on grounds that still hold: implement until the Phase A backlog of 12 open PRs has explicit outcomes, issue-poll permanently, superseded by the Temporal IssuePollWorkflow schedule. Cadence is unchanged at :15 hourly, so the first run lands within the hour and Forbid still prevents overlap.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @mashkovd's task in 49s —— View job Code ReviewCommit: Summary
FindingsThis is a trivial configuration change: toggling No issues found — the change is straightforward and the added documentation is thorough:
Verdict: ✅ APPROVED — No P1/P2 findings. Good to merge. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что меняется
mctl-agents-incidents:suspend: true → false. Расписание не трогается —15 * * * *,concurrencyPolicy: Forbid.Два блокера, и это были разные блокера
Приостановлен 29 июля. Важная деталь: причина, записанная в файле, и причина, которую все помнят, — не одно и то же. Проверил обе по факту, а не по changelog.
1. Записанная здесь: незасеянный
claude-code-oauth-token-2. Без второго аккаунта fallback-шаг валил весь прогон.2. Та, которую помнят: диагностированные тикеты вечно висели в
analyzing. Чинит статусescalatedизmctl-agent1.16.0.Снять suspend потому, что починен второй, пока первый ещё держится, — значит вернуть ровно тот отказ, ради предотвращения которого приостановка и делалась. Они разошлись случайно и закрылись тоже случайно вместе.
Отдельно: релиз выйдет как 1.16.0, а не 1.15.7 — коммит помечен
feat:, release-please делает minor. Если где-то гейт записан как «после 1.15.7», это значение уже не появится.Что остаётся приостановленным и почему
Проверил соседей — у них свои, всё ещё действующие основания, поэтому трогать их нельзя:
mctl-agents-implementmctl-agents-issue-pollIssuePollWorkflowПроверка после мержа
Первый прогон — в ближайшие
:15. Смотреть:Признак, что блокер 1 действительно снят: если основной аккаунт упрётся в лимит,
shepherd-fallback/run-fallback должен отработать на token-2, а не свалиться с exit 1.Контекст
Последний пункт вечернего плана по preprod. Смежное:
mctl-api4.32.6,mctl-docs#85,gitops#867.