Repository navigation
chore(agents): classify reconcile as not governed (no MCTL_TOKEN) - #2109
Merged
Merged
Conversation
The reconcile template runs run_shepherd --reconcile with no model session and maps no MCTL_TOKEN, so the mctl-api approvals backend could not even authenticate there. Classify it governed: false with the mechanically checked no-mctl-token boundary instead of leaving it staged. Refs #1980
mashkovd
marked this pull request as ready for review
October 23, 2026 22:21
|
Claude finished @mashkovd's task in 13s —— View job Review of PR #2109Approved. I found no P1, P2 or P3 issues.
The PR body says it waits for the owner's OK to keep reconcile non-governed. That sign-off is still needed before merge. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Antigravity (agy) review — informationalModel: gemini-3.8-flash-high · commit No significant issues found. |
Member
Author
|
Owner OK given on 2026-10-24 for all five staged-surface PRs (#2105 implement, #2106 run, #2107 shepherd, #2108 worker-control; #2109 keeps reconcile non-governed). Merging one at a time; each governed surface is then checked on a live run for POLICY_DECISION lines with the mctl-api backend, and rolled back if it breaks. |
This was referenced Oct 23, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1980 (mctlhq/.github#181 governance tails). Draft: waits for the owner's OK to keep reconcile non-governed.
The reconcile template (
run_shepherd --reconcile) has no model session and maps noMCTL_TOKEN; it only rewrites.status.yaml, whichcommit-and-pushre-checks. SettingMCTL_POLICY_APPROVALS=mctl-apithere could not even authenticate, so any REQUIRE_APPROVAL lookup would fail closed. Instead of leaving itrollout: staged, classify itgoverned: falsewith theno-mctl-tokenboundary, whichtests/test_policy_checkpoint_coverage.pychecks mechanically (CI fails if the template ever maps MCTL_TOKEN).🤖 Generated with Claude Code