Repository navigation
feat(agents): govern implement with the mctl-api approvals backend - #2105
Merged
Merged
Conversation
Sets MCTL_POLICY_APPROVALS=mctl-api on the implement template and drops its rollout: staged marker, as investigate did. A non-read mcp__mctl__* call from the implementer then creates or redeems a durable approval in mctl-api instead of being blocked outright. Refs #1980
mashkovd
marked this pull request as ready for review
October 23, 2026 22:21
|
Claude finished @mashkovd's task in 16s —— View job Review of #2105
Verdict: approved, 0 P1 / 0 P2 / 0 P3.
|
Contributor
Antigravity (agy) review — informationalModel: gemini-3.8-flash-high · commit No significant issues found. |
This was referenced Oct 23, 2026
Member
Author
|
Owner OK given on 2026-10-24 for all five staged-surface PRs (#2105 implement, #2106 run, #2107 shepherd, #2108 worker-control; #2109 keeps reconcile non-governed). Merging one at a time; each governed surface is then checked on a live run for POLICY_DECISION lines with the mctl-api backend, and rolled back if it breaks. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: prod behaviour flip, waits for an explicit owner OK for this surface (mctlhq/.github#181 governance tails).
Refs #1980. Image on the surface: mctl-agents 1.95.0 >=
min_approvals_version1.86.1.Rollback: revert this PR (the surface returns to
NO_APPROVALS, fail closed) and mark the manifest entrygoverned: false,boundary: bypass-openwith atracked_by.Verification after merge: one live run of the surface;
POLICY_DECISIONlines name the mctl-api backend and no legitimate run is refused.What changes: the implementer's model session has
mcp__mctl__*tools; a non-read one now creates or redeems a durable approval in mctl-api instead of being blocked outright. Its own GitHub actions (push, PR create) are ALLOW rules and do not change. No implementer prompt directs the model to a governed mctl tool today, so no run is expected to hit it.🤖 Generated with Claude Code