Repository navigation
feat(agents): enforce run tokens for investigate again - #2099
Merged
Merged
Conversation
mctl-api 4.117.0 binds investigate runs submitted without an execution_id, which is what failed the first enforce attempt. Observe then showed a run without an execution exchange successfully.
|
Claude finished @mashkovd's task in 16s —— View job Review of PR #2099
The change is a single env var flip in I only read the diff. I did not run any checks. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Antigravity (agy) review — informationalModel: gemini-3.8-flash-high · commit No significant issues found. |
mashkovd
added a commit
that referenced
this pull request
Oct 24, 2026
Option (c) on mctlhq/mctl-agents#717: the investigator's MCP connection (enforce since #2099) and, from mctl-agents 1.98.0, its own work-item REST calls use the scoped investigate run token. With MCTL_TOKEN gone from the container, the agent's tool subprocesses can reach only what that scope admits, so investigate-bash moves from bypass-open to no-mctl-token. The coverage check now accepts a no-mctl-token transport entry when its surface maps no MCTL_TOKEN and runs at least the entry's min_image_version, so this cannot go live on an image that still reads MCTL_TOKEN for REST. Refs mctlhq/mctl-agents#717, #1980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables enforce for investigate after the rollback in #2086. Owner OK given 2026-10-23.
Why it is safe now
execution_id: the exchange could not bind it.mctl-agents-investigate-408bdfbd(13:22Z, noexecution_id):run token: observe, exchange ok, scope=investigate, with auditagent_run_token.exchangeandagent_run_token.revokesucceeded.mctl-agents-investigate-896df827(with anexecution_id): exchange ok.agent_scope_denied, so each run proves the refusal.Rollback
Set
MCTL_RUN_TOKEN_MODEback toobserve, as in #2086.🤖 Generated with Claude Code