Repository navigation
fix(agents): return investigate run tokens to observe - #2086
Merged
Merged
Conversation
Investigate runs submitted without an execution_id cannot be bound to a run token, so enforce failed them at the exchange. Observe keeps the exchange visible without failing those runs.
mashkovd
marked this pull request as ready for review
October 23, 2026 09:25
|
Claude finished @mashkovd's task in 32s —— View job Review complete ✅
Verdict: Approved. This is a trivial config rollback — flips |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Antigravity (agy) review — informationalModel: gemini-3.8-flash-high · commit No significant issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback of #2078 for investigate runs.
The first enforced investigate run after #2078 (
mctl-agents-investigate-b478e8fa, 2026-10-23 06:52Z) was submitted with an emptyexecution_id. mctl-api cannot bind such a run to a run token, so the exchange was refused (403) and enforce failed the run as designed. Investigate therefore has an entry path that enforce does not cover yet.This sets
MCTL_RUN_TOKEN_MODEback toobserve: the exchange is still attempted and audited, and a refused exchange is logged instead of failing the run. Enforce returns once every investigate entry path carries an execution, tracked in mctlhq/mctl-agents#752.Draft until the owner OKs the rollback.
🤖 Generated with Claude Code