Skip to content

chore(portal): drop the seerrsense closed-output-schemas waiver - #1414

Merged
mashkovd merged 1 commit into
mainfrom
chore/portal-drop-seerrsense-waiver
Sep 26, 2026
Merged

mashkovd merged 1 commit into
mainfrom
chore/portal-drop-seerrsense-waiver

Conversation

@mashkovd

Copy link
Copy Markdown
Member

seerrsense 1.11.1 is deployed. It includes mctlhq/seerrsense#79, which opens every output schema. A forced portal sync (last_synced 2026-09-26 12:43:31) shows 0 additionalProperties:false across all five stored outputSchemas. seerrsense_whoami answers through the portal.

The ("seerrsense", "closed-output-schemas") waiver now covers nothing. A dead waiver is reported as an error, so it goes before the nightly run. The only waiver left is tg's flag-gated prepare_send_message.

Local check: portal-catalogue-drift.py --selftest passes. After merge I'll dispatch cloudflare-drift to confirm.

Refs #1363, #1406

🤖 Generated with Claude Code

https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry

seerrsense 1.11.1 (mctlhq/seerrsense#79) opens every output schema. It is
deployed, and a forced portal sync at 12:43 shows zero
additionalProperties:false across all five stored outputSchemas. The only
waiver left is tg's flag-gated prepare_send_message.

Refs #1363, #1406
Claude-Session: https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry
Copilot AI lite review requested due to automatic review settings September 26, 2026 12:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 1m 29s —— View job


Review complete ✅

  • Fetch diff e7d20d93...8306fefa
  • Read KNOWN_STALE selftest logic (dead-waiver detection, waiver_is_wellformed) to confirm removal is warranted
  • Check for stray references to the removed key elsewhere in the file/repo
  • Submit verdict

Verdict: Approved (no P1/P2 findings, 0 P3)

This is a pure data-only removal — the ("seerrsense", "closed-output-schemas") entry is deleted from KNOWN_STALE in scripts/portal-catalogue-drift.py, no logic touched.

Confirmed the removal is correct, not just cosmetic:

  • The maintenance check at portal-catalogue-drift.py:544-553 is exactly the "waiver excuses nothing — delete it" detector the PR description refers to; per the PR's own selftest/portal sync data, none of the five closed-output-schema findings this waiver used to cover still fire after seerrsense 1.11.1, so leaving the entry in place would trip that check on the next nightly run.
  • Grepped for other references to the removed key/tuple — the only remaining seerrsense mentions in the file are the OWNERS map entry (line 102, unrelated) and a historical comment (line 435) that's still accurate. Nothing else depends on the removed entry.
  • The remaining ("tg", "missing-tool") waiver is untouched and still well-formed.

Treated as trivial per review guidelines (config/data removal, no logic change) — approved directly.

@github-actions

Copy link
Copy Markdown
Contributor

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit 8306fef.

No significant issues found.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: removes only the now-dead seerrsense/closed-output-schemas KNOWN_STALE entry (0 findings still map to it per the maintenance check at portal-catalogue-drift.py:544-553); no logic change, no stray references left.

@mashkovd
mashkovd merged commit fc8331e into main Sep 26, 2026
18 checks passed
@mashkovd
mashkovd deleted the chore/portal-drop-seerrsense-waiver branch September 26, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants