Skip to content

chore(portal): waive the two known catalogue findings - #1406

Merged
mashkovd merged 1 commit into
mainfrom
chore/portal-catalogue-waivers
Sep 26, 2026
Merged

mashkovd merged 1 commit into
mainfrom
chore/portal-catalogue-waivers

Conversation

@mashkovd

Copy link
Copy Markdown
Member

Why

After #1402–#1404 the portal drift job's plan and registration check are green (run 36227562842). The job is still red: the catalogue check exits 1 on two findings that a re-snapshot, the remedy it prescribes, cannot fix.

server finding why a re-snapshot can't fix it waiver until
projects 8 closed outputSchemas Closed at the source in projects-mcp. projects is DCR, so the catalogue is live. 2026-10-15 (same as seerrsense)
tg prepare_send_message missing Registered only with MCP_APPS_ENABLED=true (mctl-telegram#569), which prod does not set. Its allowlist entry is enabled: false. After the DCR move tg synced at 07:19 and the tool is still absent. 2026-12-31

Each waiver names its tools exactly, so a new tool with the same problem still fails.

Local check: portal-catalogue-drift.py --selftest, all ok.

Refs #1363, #1370

🤖 Generated with Claude Code

https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry

The catalogue check has been red on two findings that a re-snapshot, its
standard remedy, cannot fix:

- projects: eight closed output schemas, closed at the source
  (projects-mcp), and projects is DCR, so the catalogue is live, not a
  stale snapshot. Waived until 2026-10-15, like seerrsense.
- tg: prepare_send_message is registered only with MCP_APPS_ENABLED=true,
  which production does not set; its allowlist entry is disabled for that
  reason. tg synced at 07:19 after its DCR move and the tool is still
  absent. Waived until 2026-12-31.

Both waivers name their tools exactly, so a new tool with the same problem
still fails.

Refs #1363, #1370
Claude-Session: https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry
Copilot AI lite review requested due to automatic review settings September 26, 2026 07:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 1m 24s —— View job


Review checklist

  • Read the diff (git diff 5d961b3c9...2f182d569) and surrounding KNOWN_STALE/apply_waivers/waiver_is_wellformed machinery
  • Verified waiver shape against waiver_is_wellformed (tuple key, key[0] in OWNERS, key[1] in KINDS, tools non-empty list of strings, until a valid ISO date, why present)
  • Cross-checked tool lists/dates against the PR description table
  • Posted verdict

Findings

No P1/P2/P3 findings.

  • ("projects", "closed-output-schemas"): projects is in OWNERS (line 99), closed-output-schemas is a valid KINDS member, the 8 named tools match the PR's "8 closed outputSchemas" claim, until: 2026-10-15 matches the table, and why cites the tracking issues.
  • ("tg", "missing-tool"): tg is in OWNERS, missing-tool is a valid kind, until: 2026-12-31 matches the table, single-tool list matches how missing-tool findings are emitted (one per tool, per the comment at line ~432-436).
  • Indentation, comment style, and trailing-comma formatting match the existing seerrsense waiver entry exactly — no style drift.
  • Both waivers are dated and specific enough that apply_waivers' maintenance checks (dead waiver / partial-coverage / new-tool-not-covered) will catch drift automatically, consistent with this file's stated design.

Nothing to fix. Approving.

@github-actions

Copy link
Copy Markdown
Contributor

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit 2f182d5.

No significant issues found.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No P1/P2 findings (0 P3). Two new KNOWN_STALE waivers are well-formed per waiver_is_wellformed (valid OWNERS/KINDS, dated, tools listed, why cited) and match the PR's stated tool lists/dates. Good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants