Skip to content

feat(seerrsense): allow the portal's dashboard callback for DCR - #1368

Merged
mashkovd merged 1 commit into
mainfrom
feat/seerrsense-dcr-dashboard-callback
Sep 24, 2026
Merged

mashkovd merged 1 commit into
mainfrom
feat/seerrsense-dcr-dashboard-callback

Conversation

@mashkovd

Copy link
Copy Markdown
Member

Follow-up to #1367, part of #1363.

In automatic mode, the Cloudflare portal's admin login ("Authenticate server") uses the dashboard callback https://dash.cloudflare.com/<account>/one/access-controls/ai-controls/mcp-server/oauth-callback/<server_id>, not only https://mcp.mctl.ai/servers-callback. This was observed live on 2026-09-24 while signing coolify in (see the #1363 comment).

seerrsense accepts a registration only if every redirect is on the allowlist, so with servers-callback alone the portal's registration would get 400 invalid_redirect_uri. This PR adds the exact callback for server id seerrsense in this account:

SEERRSENSE_DCR_REDIRECT_URIS: https://mcp.mctl.ai/servers-callback,https://dash.cloudflare.com/6a09f637d20e1f66a8e9d45ebe778058/one/access-controls/ai-controls/mcp-server/oauth-callback/seerrsense

Matching is exact (isAllowedRedirectUri), and each entry is validated as a URL at load time. The same rule correction is recorded in mctlhq/.github#137.

🤖 Generated with Claude Code

https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry

This was measured on 2026-09-24 while signing coolify in. In automatic mode,
the Cloudflare portal's admin login uses
https://dash.cloudflare.com/<account>/one/access-controls/ai-controls/mcp-server/oauth-callback/<server_id>
as its redirect_uri, so the DCR registration includes that callback.
seerrsense accepts a registration only if every redirect is on its allowlist,
so with servers-callback alone the portal would be refused with 400 and the
switch to automatic mode (#1363) would fail.

This adds the exact dashboard callback for server id `seerrsense` in this
account. Matching is exact-match only.

Claude-Session: https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry
Copilot AI lite review requested due to automatic review settings September 24, 2026 20:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 17s —— View job


Review

Trivial config change: adds a second allowed redirect URI (Cloudflare dashboard callback) to SEERRSENSE_DCR_REDIRECT_URIS in values.yaml, matching the PR description. No logic, RBAC, or manifest changes.

Approved.

@github-actions

Copy link
Copy Markdown
Contributor

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit a41d518.

No significant issues found.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial env-var change: adds allowlisted DCR redirect URI. No logic/RBAC/manifest impact.

@mashkovd
mashkovd merged commit c11b608 into main Sep 24, 2026
20 checks passed
@mashkovd
mashkovd deleted the feat/seerrsense-dcr-dashboard-callback branch September 24, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants