Skip to content

feat(seerrsense): turn on DCR for the Cloudflare portal callback - #1367

Merged
mashkovd merged 1 commit into
mainfrom
feat/seerrsense-dcr-portal-callback
Sep 24, 2026
Merged

mashkovd merged 1 commit into
mainfrom
feat/seerrsense-dcr-portal-callback

Conversation

@mashkovd

Copy link
Copy Markdown
Member

Task 0 of #1363.

Sets SEERRSENSE_DCR_REDIRECT_URIS: https://mcp.mctl.ai/servers-callback in services/labs/seerrsense/values.yaml. seerrsense 1.11.0 (seerrsense#74) ships DCR off unless this is set.

Effect after ArgoCD sync

  • registration_endpoint: https://seerrsense.mctl.ai/register appears in /.well-known/oauth-authorization-server.
  • POST /register with redirect_uris: ["https://mcp.mctl.ai/servers-callback"] returns 201 and a dcr_… client. Any other redirect gets 400 invalid_redirect_uri.
  • A DCR client that names no scope is granted seerr:read seerr:request.

Nothing user-visible changes yet. The portal keeps using its manual pre-registered cloudflare-portal-mcp client until #1363 switches the upstream to automatic mode.

Rollback

Remove the line, or set it to "". Registration turns off, and already-registered DCR clients stop resolving (seerrsense#75 P1 fix).

🤖 Generated with Claude Code

https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry

This is task 0 of #1363. seerrsense 1.11.0 (seerrsense#74) ships a DCR fallback
that is off unless SEERRSENSE_DCR_REDIRECT_URIS names the callbacks allowed to
register. This change names the one callback the portal uses,
https://mcp.mctl.ai/servers-callback.

After the rollout:
- registration_endpoint appears in seerrsense's authorization-server metadata;
- a registration for that callback succeeds, and any other callback gets 400.

The portal still uses its manual pre-registered client (cloudflare-portal-mcp)
until #1363 switches the upstream to automatic mode, so nothing a user sees
changes here.

Claude-Session: https://claude.ai/code/session_01T5nLoYSquzMsGsdS64wvry
Copilot AI lite review requested due to automatic review settings September 24, 2026 17:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 26s —— View job


Review complete ✅

  • Fetch diff (git diff a6b774cd...134a9d2b)
  • Assess triviality / correctness
  • Submit verdict

Verdict: APPROVED

Trivial, single-line change: adds SEERRSENSE_DCR_REDIRECT_URIS: https://mcp.mctl.ai/servers-callback to platform-gitops/services/labs/seerrsense/values.yaml, with a comment block explaining behavior. No templates, RBAC, resource limits, or ApplicationSet/Application specs touched, and no secrets are involved (the value is a public callback URL). Matches the config/env-var trivial-change criteria, so it was approved with a one-line rationale per policy.

@github-actions

Copy link
Copy Markdown
Contributor

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit 134a9d2.

No significant issues found.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: adds one env var (SEERRSENSE_DCR_REDIRECT_URIS) to values.yaml, no logic/template changes.

@mashkovd
mashkovd merged commit 27b3bff into main Sep 24, 2026
20 checks passed
@mashkovd
mashkovd deleted the feat/seerrsense-dcr-portal-callback branch September 24, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants