Skip to content

docs: document release/tagging convention - #27

Merged
mashkovd merged 1 commit into
mainfrom
docs/release-convention
Jul 2, 2026
Merged

mashkovd merged 1 commit into
mainfrom
docs/release-convention

Conversation

@mashkovd

@mashkovd mashkovd commented Jul 2, 2026

Copy link
Copy Markdown
Member

Adds a Releases section to CLAUDE.md documenting how mctl-agent cuts releases.

Context: the mctlhq best-practices audit (item 3) flagged that no chore: release x.y.z commits exist across 30+ tags. mctl-agent has no release-please automation — tags are pushed manually onto feature-PR merge commits, which triggers build.yml.

This is the trivial, low-risk fix: document the existing manual flow plus the org's chore: release x.y.z commit convention so future releases are consistent. Full release-please onboarding (as used by mctl-portal) is a larger opt-in decision left to the user.

Releases were cut ad hoc by tagging merge commits directly, with no
documented convention. Record the manual flow and the chore: release
x.y.z commit expectation so future releases are consistent.
@claude

claude Bot commented Jul 2, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 27s —— View job


Release Documentation Review

✅ No P1/P2 findings, good to merge.

This is a straightforward documentation addition to CLAUDE.md that clearly documents the existing manual release process:

  • Semantic versioning convention (no v prefix)
  • CI/CD trigger mechanism via tag push
  • Manual workflow using chore: release x.y.z commits
  • Prohibition on direct main tagging

The documentation is clear, follows the existing style of CLAUDE.md, and addresses the audit finding about missing release conventions. No issues identified.


@mashkovd
mashkovd merged commit 9a41841 into main Jul 2, 2026
2 checks passed
@mashkovd
mashkovd deleted the docs/release-convention branch July 2, 2026 06:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dedcb5e5ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CLAUDE.md
Comment on lines +43 to +45
- Semantic version tags, NO `v` prefix (e.g. `1.9.0`). Pushing a matching tag
triggers `.github/workflows/build.yml`, which builds/pushes the image and bumps
the gitops manifest.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the public release instructions too

This new no-v release convention leaves the existing README release process contradicting it: README still tells users to run git tag v1.2.3, while the workflow trigger I checked in .github/workflows/build.yml starts with a numeric character class ([0-9]*.[0-9]*.[0-9]*) and therefore won't run for v... tags. Anyone following the public README after this change can still create a tag that skips the release build/GitOps bump, so please update the README release section or make one canonical doc authoritative in the same change.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant