Repository navigation
Handle a subtle difference in the reporting of uploaded one-time key counts between the supported sync APIs - #6780
Merged
Conversation
…e convenient place
…to a helper This is happening because we need different receive_sync_changes methods based on the sync API we're using.
poljar
requested review from
jmartinesp and
uhoreg
and removed request for
a team
July 22, 2026 12:09
jmartinesp
requested changes
Jul 22, 2026
jmartinesp
left a comment
jmartinesp
left a comment
Contributor
There was a problem hiding this comment.
LGTM in general, but I think this parameter is wrong.
| unused_fallback_keys: Option<&[OneTimeKeyAlgorithm]>, | ||
| next_batch_token: Option<String>, | ||
| decryption_settings: &DecryptionSettings, | ||
| msc_4188: bool, |
Contributor
There was a problem hiding this comment.
Is it MSC 4186 or 4188?
andybalaam
requested changes
Jul 22, 2026
andybalaam
left a comment
andybalaam
left a comment
Member
There was a problem hiding this comment.
Looks good, but I'd like to see a test for the new behaviour. (Maybe there is one already?)
andybalaam
approved these changes
Jul 22, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6780 +/- ##
==========================================
- Coverage 90.01% 90.01% -0.01%
==========================================
Files 405 405
Lines 112979 113046 +67
Branches 112979 113046 +67
==========================================
+ Hits 101700 101755 +55
- Misses 7426 7437 +11
- Partials 3853 3854 +1 ☔ View full report in Codecov by Harness. |
jmartinesp
approved these changes
Jul 28, 2026
Contributor
|
Sorry for the long delay, I didn't realise my previous review was blocking merging this 😓 . |
This was referenced Aug 25, 2026
This was referenced Aug 27, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classic sync and sliding sync report one-time key counts slightly differently.
The following interpretation is used when one-time key counts are absent:
0This PR adds a separate method for the MSC4186-specific sync responses.