Repository navigation
Combine crypto-related receiveSyncChanges calls into one - #5503
Merged
Merged
Conversation
kaylendog
changed the title
receiveSyncChanges calls into onereceiveSyncChanges calls into one
4 tasks done
This was referenced Aug 27, 2026
uhoreg
reviewed
Aug 27, 2026
uhoreg
left a comment
uhoreg
left a comment
Member
There was a problem hiding this comment.
Looks pretty good so far. I assume that the sliding-sync-sdk.ts changes will be updated to use matrix-org/matrix-sdk-crypto-wasm#345
kaylendog
force-pushed
the
kaylendog/fix/single-sync
branch
from
August 28, 2026 10:20
7d2eb92 to
92ec56a
Compare
kaylendog
marked this pull request as ready for review
August 28, 2026 11:13
t3chguy
approved these changes
Aug 28, 2026
4 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-rust-sdk#6780 fixed a long-standing issue in the Rust SDK where
OlmMachine::receive_sync_changesincorrectly treated a missingone_time_keys_countsas "no change", when (for sync v2) this means "no keys". This behaviour made it into the WASM SDK in release v18.5.0, which causes clients written using the JS SDK to endlessly upload OTKs on every sync.This is resolved by this PR by correctly calling either
OlmMachine.receiveSyncChangesor the newOlmMachine.receiveSyncChangesonce per sync, as opposed to the three calls previously made bypreprocessToDeviceMessages,processDeviceLists, andprocessKeyCounts.Fixes #5501
Checklist
public/exportedsymbols have accurate TSDoc documentation.