Errors on Android don't have a message: `Unknown std::runtime_error error`

[mrousavy]

What's happening?

On Android, errors / exceptions don't have a proper message, and always resort to Unknown T error (e.g. Unknown std::runtime_error error) instead of using it's message (what()).

The same goes for Promise<T>.

I can't really figure out why this is happening - my best guess is that there is some ABI issue with the libc++ standard used by Android NDK, and since errors in Nitro are implemented using std::exception_ptr, the methods current_exception()/rethrow_exception(..) are broken in Android.
I created an issue in the react-native repo: react/react-native#48027

Reproduceable Code

class MyHybrid: public MyHybridSpec {
  // ...
public:
  void someFunc() override {
    throw std::runtime_error("my message!");
  }
};

Relevant log output

iOS ✅:

MyHybrid.someFunc(): my message!

Android ❌:

MyHybrid.someFunc() threw an unknown std::runtime_error error.

Device

Huawei P10

Nitro Modules Version

0.18.1

Nitrogen Version

0.18.1

Can you reproduce this issue in the Nitro Example app here?

Yes, I can reproduce the same issue in the Example app here

Additional information

• I am using Expo
• I am using Nitrogen (nitro-codegen)
• I have read and followed the Troubleshooting Guide.
• I created a reproduction PR to reproduce this issue here in the nitro repo. (See Contributing for more information)
• I searched for similar issues in this repository and found none.

[mrousavy]

cc @Szymon20000

[mrousavy]

Actually this is a react-native bug, not a Nitro bug. It can be reproduced in a blank new react-native 0.76 or 0.77 app. react/react-native#48027

[jobpaardekooper]

Since this is a RN bug, do you know any issue number/link on their repo that tracks this?

[mrousavy]

yea see my comment directly above yours

[jobpaardekooper]

I don't know how I missed that... sorry. Thanks for the reply.

[iwater]

this also show on ios platform with react-native@0.76.5

Error: `NitroModulesProxy.createHybridObject(...)` threw an unknown std::runtime_error error.

[mrousavy]

@iwater i cannot reproduce this on iOS - which Nitro version? can you reproduce this in the NitroExample app here?

[iwater]

0.20.1，I just use template folder code as library template and add Math code from doc, then got that error message , I just put that code on https://github.com/iwater/react-native-nitro-crypto2

[iwater]

sorry, I just create a new project, it can show detail error message now.

[Nlcke]

Is unknown facebook::jni::JniException error related to this issue? For example:

(NOBRIDGE) ERROR  [Error: `Math.throwError(...)` threw an unknown facebook::jni::JniException error.]

The Kotlin class is:

package com.margelo.nitro.math

class HybridMath : HybridMathSpec() {
    override val memorySize = 0L

    override fun throwError() {
        throw Error("THIS IS ERROR!")
    }
}

[mrousavy]

Yup, same story here.

Unfortunately caused by the new SoLoader merging changes introduced in RN 0.76. Not sure if this only affects Nitro Modules or also (C++) TurboModules as well.

@Nlcke If you can try what @cortinico suggested in this comment, that would be a huge help.

[cortinico]

Unfortunately caused by the new SoLoader merging changes introduced in RN 0.76

Has this been confirmed as being the root cause?

[mrousavy]

Not 100%, no. Should've phrased this differently.
But I'm pretty sure we can figure that out if we try your suggestion in your comment.

[thecynicalpaul]

I am experiencing the same on iOS.
Simply doing something along the lines of

std::shared_ptr<margelo::nitro::Promise<void>> ClassName::asyncMethod() {
  return Promise<void>::async([this]() -> void {
    throw std::runtime_error("GENERIC RUNTIME ERROR");
  });
}

Throws an [Error: Unknown std::runtime_error error.]. In other cases of actual failures, I get Unknown St13runtime_error error.

react-native@0.75.4
nitro@0.22.1

Some info from our podspec:

s.pod_target_xcconfig = {
    'USE_HEADERMAP' => 'YES',
    'DEFINES_MODULE' => 'YES',
    'CLANG_CXX_LANGUAGE_STANDARD' => 'c++20',
    'SWIFT_COMPILATION_MODE' => 'wholemodule',
    'GCC_PREPROCESSOR_DEFINITIONS' => '$(inherited) FOLLY_NO_CONFIG FOLLY_CFG_NO_COROUTINES MINIAUDIO_IMPLEMENTATION MA_NO_RUNTIME_LINKING'
  }

  s.frameworks =
    "Foundation",
    "AVFoundation",
    "AVFAudio",
    "CoreFoundation",
    "CoreAudio",
    "AudioToolbox"
  

  s.subspec "MiniAudio" do |ss|
    ...
    ss.compiler_flags = "-x objective-c -lpthread -lm"
  end