Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Flat markers should have screen-centered vanishing point #5218

Closed

Description

@1ec5

As seen in #3276 (comment), the vanishing point for a flat marker view on a tilted map is always somewhere directly above the marker view. So in the screenshot above, the flag to the right is symmetrical across the y axis, whereas you’d expect both the left and right sides of the flag to parallel the north-south streets they’re being drawn atop:

device-2016-06-02-183106

If the perspective transformation is executed correctly, you shouldn’t be able to tell that the flag is a marker view. As you pan the map from side to side, the streets shouldn’t appear to be moving relative to the flag. In graphics terms, the vanishing point for the transform should be horizontally centered; it shouldn’t vary by the x position of the marker view.

Due to #5090, we haven’t run into this issue on iOS yet, but it’s something to be aware of.

/cc @tobrun @bleege @boundsj @friedbunny

Activity

  1. added
    AndroidMapbox Maps SDK for Android
    annotationsAnnotations on iOS and macOS or markers on Android
    on Jun 2, 2016
  2. changed the title [-]Flat markers should have fixed vanishing point[/-] [+]Flat markers should have screen-centered vanishing point[/+] on Jun 2, 2016
  3. tobrun commented on Jun 3, 2016

    @tobrun
    Member

    Thank for the 👀 @1ec5, getting this in will probably require the addition of a container view since we need to be able to control the onDraw and do the projection ourselves. (instead of relying on setRotationX of the user provided view).

  4. tobrun commented on Oct 10, 2017

    @tobrun
    Member

    with #9782 we have deprecated MarkerView, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    AndroidMapbox Maps SDK for AndroidannotationsAnnotations on iOS and macOS or markers on Androidbug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions