Try other placements when the the icon is collided out - #8803
Merged
Merged
Conversation
Merged
ansis
force-pushed
the
fix-icon-text-fit-variable
branch
from
October 10, 2019 18:17
9e0e2ee to
c1d6294
Compare
When icon-text-fit-padding is used the collision box of the icon is different than the collision box of the text. It now checks whether the icon box fits when choosing a variable text position.
ansis
force-pushed
the
fix-icon-text-fit-variable
branch
from
October 15, 2019 21:22
c1d6294 to
9e7d759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol placement currently doesn't try other placements for
text-variable-anchorif the associated icon has a collision, but not the text itself. This patch fixes that.Before (note how the entire symbol vanishes instead of using another anchor):
After: