Conversation
7 tasks
Contributor
Author
|
As far as I can tell all that is remaining is #8806. I'll close this pr and open a new one for that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses : #8583
This is still very much a WIP that doesn't work yet. mapbox/mapbox-gl-native#15367.
When I got to porting the changes in
placement.cppI tried adding the all at once because I didn't see a clear way of doing it incrementally. But that may have not been the best plan since it doesn't work and I'm not sure if it's close or if there are many large bugs remaining.The next steps for working on this could be to try run
yarn run test-render icon-text-fitand debug the crashes and problems one by one as they appear. But it may actually be better to do a careful readthrough of the original PR and make sure everything is included. Finally, if that doesn't work, it might be easiest to start with a fresh branch and gradually cherry-pick changes from this branch over or use it as a guide.