Repository navigation
Conversation
ChrisLoer
approved these changes
Aug 23, 2017
Contributor
There was a problem hiding this comment.
This is 💯 (err, pending figuring out the test hang?).
It's not directly related to this PR, but have you seen that @ivovandongen is working on the throttling on the native side to have better control over which scheduler we use (mapbox/mapbox-gl-native#9611)?
Also on the viewport-collision branch (#5150), the "redoPlacement" use case will disappear, possibly leaving this code orphaned.
| }); | ||
| }; | ||
|
|
||
| /** |
mourner
force-pushed
the
simpler-throttler
branch
from
August 23, 2017 15:58
0f55eac to
6c6364c
Compare
Member
Author
|
@ChrisLoer sure — if #5150 is close to shipping, feel free to close the PR. |
Member
Author
|
Not sure what's going on with the freezing tests though, I thought this was something on the Circle side... |
Member
Author
|
Closing since this will be irrelevant with #5150. We can revisit when we need throttling code again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the throttling code simpler and more idiomatic while investigating #5185.