Repository navigation
Fix redoPlacement race condition - #5185
Conversation
d1b1bb5 to
a4b7243
Compare
|
Not sure if it's worth adding a test for this tricky condition if the placement code is fully rewritten in the |
|
I think this change would turn the Did the throttling changes cause #3700, or did they just change the timing so that it was easier to expose this condition? |
a4b7243 to
80d3d89
Compare
|
@ChrisLoer fixed it to add the |
ChrisLoer
left a comment
There was a problem hiding this comment.
Cool, I think it's worth merging.
Closes #3700. The condition occurred when a tile requested redoPlacement (which sent a redoPlacement request to the worker) and then shortly got removed (before getting response to redoPlacement back from the worker) —
stopPlacementThrottlerdid not prevent redoPlacement from running in this case because it was past the throttling phase.