Repository navigation
chore: align Rust style and lint gates with Engine - #1743
Merged
Merged
Conversation
bmuddha
marked this pull request as ready for review
September 30, 2026 13:34
bmuddha
enabled auto-merge (squash)
September 30, 2026 13:34
bmuddha
disabled auto-merge
September 30, 2026 13:34
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MBV now uses Engine-aligned Rust formatting and lint rules across the main and integration workspaces. The stricter gate exposed poisonable locks and panic assumptions in scheduling, RPC, and validator startup; those paths now use parking_lot or explicit error/ownership transitions. Documentation and sleep lints remain deferred, and test fixtures plus legacy conversion/storage code retain scoped exemptions.
Closes #1742
Impact
The formatter touches most crates. The behavior changes are concentrated in committor scheduling, Aperture's ledger-read and response paths, and one-shot validator service startup.
Reviewer notes
Please focus on the committor scheduler's completion/poisoning behavior and the validator startup ownership transition; the remaining churn is mostly formatting and lint visibility.