Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
The independent preflight change from Closing this duplicate preflight review. The separate Link-restoration review and its release hold remain in place. |
Summary
Connected-stop preflight must prove the identity of the exact local runtime before any service-manager or process-stop mutation. A named or responding loopback process is insufficient, and preflight must not disclose reusable management credentials.
This PR is stacked on #774, which owns transport-specific routing restoration. The history-preserving integration resolves the conflicting stop implementation, fixtures and documentation while retaining both behaviors:
GET /api/stopand a matching response proof. Native client-role listeners own their transport-specific signal cleanup.The base is the open #774 branch so the review diff contains the additional identity protection. After #774 lands, this child should target
dev.Verification
Current head:
f5c1707baf087f53bf151ee75fc3943430a38063. Ordered parents: previous #788 head4c0404785ae610bc3c6996b1d6fba99cd3a24059, then verified #774 head7458fe370227ba78db0917e21792a144100f2786. Remote tree was checked against the exact local validated tree before publication; no history was rewritten.Bun 1.4.4:
100755.The previous #788 head completed Cross-platform CI, Catalog async contracts, and Service lifecycle. The #774 parent completed its required current-head workflows as well. These results are historical evidence; the current combined-head results are recorded below.
Focused and filtered selections follow the repository's concurrent-worktree resource exception. No full local repository suite was rerun for the integration. Earlier bounded changed-suite attempts were incomplete and remain non-passing evidence; policy-skipped macOS/Windows jobs are not native-platform validation.
Current-head hosted CI
Head
f5c1707baf087f53bf151ee75fc3943430a38063completed Cross-platform CI, Catalog async contracts, Service lifecycle successfully. Skipped platform jobs remain outside the native acceptance evidence. The PR remains draft for maintainer security review.Checklist
The PR remains draft.