Skip to content

feat(cli): complete account policy and runtime settings workflows - #6539

Merged
lidge-jun merged 16 commits into
devfrom
codex/cli-parity-accounts-settings
Oct 4, 2026
Merged

lidge-jun merged 16 commits into
devfrom
codex/cli-parity-accounts-settings

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add named account pool policy, per-account threshold, explicit paid-credit permission, quota-window activation and read-only Anthropic grant-status commands. Login gains flow-specific browser/add-account controls; explicit live logout preserves local/live ownership.
  • Expose memory/compaction model overrides, injection default sync, sidecar stream/timeout, dashboard settings and explicit live V2 commands. Saved, pending, refused and unverified results remain distinct, with safe JSON and nonzero partial outcomes.
  • Synchronize capability/help discovery, generated skill chapters, operating recipes, public docs and structure ownership. Existing local defaults remain available.

Manual stack: #6526 → #6528 → #6535 → this PR. Depends on #6535; review this layer’s diff only. No GUI changes.

Verification

Stack refresh onto dev (lane L1, 2026-10-04; re-refreshed 2026-10-05 onto dev df61d03ecc), head f812563ea2da37c8b521c62f3179e953f61ef9f3. Merged the refreshed parent and fixed two semantic conflicts with dev #6562 that the clean textual merge hid: the pool DTO now carries nativeMessages for every kind, which the strict CLI schema rejected (all ocx account pool reads failed; six existing real-DTO cases in tests/cli/cli-account-policy.test.ts went red before dcd630e7e3), and a persisted save with failed bookkeeping returns warning: "config_bookkeeping_failed", which the CLI stripped (9950cd8133 keeps the fixed code in JSON and prints GUI-equivalent guidance; new case added). Account policy, pool-verb and headless-parity test files passed (217 cases). Independent security review (gpt-6.1-sol): PASS at 901c55728d; own diff confirmed unchanged after the refresh; delta bfa4d0b4de..9950cd8133 re-reviewed PASS (only fixed literals projected, supported-mask write gate intact, exit codes truthful). Local checks at this head: bun scripts/file-size-ratchet.ts (pass; test-layout fixture now well under the 2000-line threshold after #6583), tests/test-layout.test.ts + tests/test-layout-tooling.test.ts (pass), bun run typecheck (pass), bun run structure:check (pass); on the stack top additionally skill:surface:check, privacy:scan and the skill/capability/ratchet test files (all pass). The full local suite was intentionally not run per maintainer instruction; broad and platform coverage is left to exact-head hosted CI: Cross-platform CI run 37217207247 (success at this head). Earlier-head CI results below are historical. Later dev moves (#6576, #6578, #6405, #6486, #6512, #6572, #6585, #6586, #6564) were merged in the same way; test-layout fixture conflicts were resolved as key unions, and this layer now packs only its own new entries in scripts/test-layout/layout.json four per line (JSON content unchanged; the file stays clear of the 2000-line threshold for unbaselined files once the stack lands).

Current-head hosted CI passed at 901c55728dfac060302a1ecc6e02488e53099224: run 37159735018, pull_request event, attempt 1; all four test shards and aggregate ci succeeded. This manual layer targets codex/cli-parity-models-routing and contains its refreshed parent plus pinned dev 0818ea1812a028e1c14cd0b0511b44863407bc52. Earlier-head results below remain historical. Optional platform jobs skipped by scope are not claimed as executed. Correct remote and independent review findings were repaired and propagated upward; no PR was merged.

  • Independent functional review: 474 focused tests passed; alias correction independently rechecked with 22 passing tests. Independent security review: 452 focused tests passed plus three alias-delta regressions. Counts overlap and are not additive.
  • Integrated capability, dispatch, skill, management-route and structure checks: 241 tests passed across nine files. V2/layout compatibility group: 153 passed.
  • bun run typecheck, bun run structure:check, bun run skill:surface:check, bun run privacy:scan: passed.
  • bun run --cwd docs-site build: 561 pages and 77,997 internal links checked.
  • 37 actual CLI subprocess scenarios passed with isolated homes, fixture management responses, blocked sockets, separate output/exit/state captures and verified teardown. No real OAuth/provider/native application operation was performed.
  • The full local suite was impractical across concurrent worktrees. Focused parsers, negative cases, real isolated server handlers and indirect source/layout checks were run; broad-suite coverage is assigned to this PR’s exact-head hosted CI. Exact-head hosted CI passed at c8d7a0ef6934f6a9bb5d7f7d4299bfb278dde3ef: run 37149364066, pull_request event, attempt 1; all four test shards and aggregate CI succeeded.
  • Hosted CI at initial head found five stale legacy-login expectations. Follow-up c8d7a0ef69 preserves all semantic assertions, adds no-request/raw-error non-disclosure checks and corrects pending exit/flow identity. The full legacy account fixture plus new login-options tests passed 233 cases; typecheck passed. Independent fixture interdiff review passed. Current-head hosted CI subsequently passed. Independent functional/security/document reviews passed; the initial CodeRabbit success was a draft-skip status and is not counted as a code review.
  • Final source-bound checks and metadata/document review are recorded in devlog/_plan/261003_cli_gui_parity/052_accounts_verification.md.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5899d311-6958-4e16-ac90-a46ee1e0be5c
📥 Commits

Reviewing files that changed from the base of the PR and between 4cc48d9 and dcdaf13.

📒 Files selected for processing (63)
  • devlog/_plan/261003_cli_gui_parity/008_task_ledger.json
  • devlog/_plan/261003_cli_gui_parity/050_accounts_runtime_settings.md
  • devlog/_plan/261003_cli_gui_parity/051_accounts_revalidation.md
  • devlog/_plan/261003_cli_gui_parity/052_accounts_verification.md
  • docs-site/src/content/docs/fr/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ja/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ko/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/reference/cli/agents.md
  • docs-site/src/content/docs/reference/cli/lifecycle.md
  • docs-site/src/content/docs/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ru/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/tr/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/zh-cn/reference/cli/providers-accounts.md
  • scripts/test-layout/layout.json
  • skills/ocx/references/01_management_surface.md
  • skills/ocx/references/01_surface_accounts.md
  • skills/ocx/references/01_surface_agents-routing.md
  • skills/ocx/references/01_surface_observe-system.md
  • skills/ocx/references/02_json_shapes.md
  • skills/ocx/references/03_recipes.md
  • skills/ocx/references/04_failure_semantics.md
  • src/cli/account-auth.ts
  • src/cli/account-policy-dto.ts
  • src/cli/account-policy.ts
  • src/cli/account-target.ts
  • src/cli/account.ts
  • src/cli/agent-runtime-settings.ts
  • src/cli/agent-settings.ts
  • src/cli/agent.ts
  • src/cli/capabilities-accounts.ts
  • src/cli/capabilities-agents-routing.ts
  • src/cli/capabilities-base.ts
  • src/cli/capabilities-observe-system.ts
  • src/cli/catalog-command-result.ts
  • src/cli/dispatch.ts
  • src/cli/logout-command.ts
  • src/cli/provider-result.ts
  • src/cli/registry.ts
  • src/cli/settings-result.ts
  • src/cli/system-command.ts
  • src/cli/system-settings-parity.ts
  • src/cli/v2-input.ts
  • src/cli/v2-local-output.ts
  • src/cli/v2-runtime.ts
  • src/cli/v2.ts
  • src/server/management/route-registry.ts
  • structure/cli-management.md
  • structure/codex-account-controls.md
  • tests/cli/cli-account-login-options.test.ts
  • tests/cli/cli-account-policy.test.ts
  • tests/cli/cli-account.test.ts
  • tests/cli/cli-agent-runtime-settings.test.ts
  • tests/cli/cli-agent-settings.test.ts
  • tests/cli/cli-capabilities.test.ts
  • tests/cli/cli-capability-account-workflows.test.ts
  • tests/cli/cli-capability-agent-workflows.test.ts
  • tests/cli/cli-dispatch.test.ts
  • tests/cli/cli-logout-runtime.test.ts
  • tests/cli/cli-system-settings-parity.test.ts
  • tests/cli/cli-v2-runtime.test.ts
  • tests/codex-integration/codex-v2-gate.test.ts
  • tests/codex-integration/multi-agent-keep-native-v1.test.ts
  • tests/fixtures/test-layout-expected.json
 ___________________________________________________
< Stack Overflow called, they want their code back. >
 ---------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 3, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review October 3, 2026 20:01
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 3, 2026 20:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T20:08:31.660996Z c8d7a0e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Dev (#6562) added nativeMessages to the unified /api/pool/settings DTO for every pool kind and to the Anthropic supported list. The strict CLI pool schema rejected it, so ocx account pool failed before any read or update. Accept the capability and project its boolean-or-null value; the existing real-DTO pool tests cover it.
Dev (#6562) answers a pool save that persisted but failed post-save bookkeeping with HTTP 200 and warning config_bookkeeping_failed. The CLI pool schema stripped it and printed plain success. Project that fixed code in JSON and print the GUI-equivalent guidance in human output; the save stays a success.
…accounts-settings

Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
Base automatically changed from codex/cli-parity-models-routing to dev October 4, 2026 19:09
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration (lidge-jun, dev only) — 2026-10-04 landing train, lane L1 stack.

  • Head: dcdaf13 — a tree-identical sync merge on top of a8d2d65 (merge commit of dev after the feat(cli): make existing management workflows discoverable #6526 squash / parent sync; git rev-parse <sha>^{tree} equal), so the CI evidence below covers the same content.
  • CI: Cross-platform CI run 37225571011 success at a8d2d65.
  • Union: static check against current dev (clean merge, layout registries parse, structure-ssot and file-size ratchet pass).
  • Review: account policy and runtime settings workflows; independent sol security review PASS bound (auth/session gates intact).
  • Landed with a merge commit (allowed by the dev ruleset) so the remaining stack stays conflict-free after the feat(cli): make existing management workflows discoverable #6526 squash.
  • Full local suite intentionally not run per maintainer instruction.
  • scripts/ci/assert-mergeable-review.sh --maintainer-integration: OK.

@lidge-jun
lidge-jun merged commit 79db47c into dev Oct 4, 2026
29 of 30 checks passed
@lidge-jun
lidge-jun deleted the codex/cli-parity-accounts-settings branch October 4, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant