Repository navigation
feat(cli): complete account policy and runtime settings workflows - #6539
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (63)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…accounts-settings
…accounts-settings
…accounts-settings
Dev (#6562) added nativeMessages to the unified /api/pool/settings DTO for every pool kind and to the Anthropic supported list. The strict CLI pool schema rejected it, so ocx account pool failed before any read or update. Accept the capability and project its boolean-or-null value; the existing real-DTO pool tests cover it.
Dev (#6562) answers a pool save that persisted but failed post-save bookkeeping with HTTP 200 and warning config_bookkeeping_failed. The CLI pool schema stripped it and printed plain success. Project that fixed code in JSON and print the GUI-equivalent guidance in human output; the save stays a success.
…accounts-settings
…accounts-settings
…accounts-settings Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
…accounts-settings
…accounts-settings
…accounts-settings
…accounts-settings
|
Maintainer integration (lidge-jun, dev only) — 2026-10-04 landing train, lane L1 stack.
|
Summary
Manual stack: #6526 → #6528 → #6535 → this PR. Depends on #6535; review this layer’s diff only. No GUI changes.
Verification
Stack refresh onto dev (lane L1, 2026-10-04; re-refreshed 2026-10-05 onto dev
df61d03ecc), headf812563ea2da37c8b521c62f3179e953f61ef9f3. Merged the refreshed parent and fixed two semantic conflicts with dev #6562 that the clean textual merge hid: the pool DTO now carriesnativeMessagesfor every kind, which the strict CLI schema rejected (allocx account poolreads failed; six existing real-DTO cases intests/cli/cli-account-policy.test.tswent red beforedcd630e7e3), and a persisted save with failed bookkeeping returnswarning: "config_bookkeeping_failed", which the CLI stripped (9950cd8133keeps the fixed code in JSON and prints GUI-equivalent guidance; new case added). Account policy, pool-verb and headless-parity test files passed (217 cases). Independent security review (gpt-6.1-sol): PASS at901c55728d; own diff confirmed unchanged after the refresh; deltabfa4d0b4de..9950cd8133re-reviewed PASS (only fixed literals projected, supported-mask write gate intact, exit codes truthful). Local checks at this head:bun scripts/file-size-ratchet.ts(pass; test-layout fixture now well under the 2000-line threshold after #6583),tests/test-layout.test.ts+tests/test-layout-tooling.test.ts(pass),bun run typecheck(pass),bun run structure:check(pass); on the stack top additionallyskill:surface:check,privacy:scanand the skill/capability/ratchet test files (all pass). The full local suite was intentionally not run per maintainer instruction; broad and platform coverage is left to exact-head hosted CI: Cross-platform CI run 37217207247 (success at this head). Earlier-head CI results below are historical. Later dev moves (#6576, #6578, #6405, #6486, #6512, #6572, #6585, #6586, #6564) were merged in the same way; test-layout fixture conflicts were resolved as key unions, and this layer now packs only its own new entries inscripts/test-layout/layout.jsonfour per line (JSON content unchanged; the file stays clear of the 2000-line threshold for unbaselined files once the stack lands).Current-head hosted CI passed at
901c55728dfac060302a1ecc6e02488e53099224: run 37159735018,pull_requestevent, attempt 1; all four test shards and aggregatecisucceeded. This manual layer targetscodex/cli-parity-models-routingand contains its refreshed parent plus pinned dev0818ea1812a028e1c14cd0b0511b44863407bc52. Earlier-head results below remain historical. Optional platform jobs skipped by scope are not claimed as executed. Correct remote and independent review findings were repaired and propagated upward; no PR was merged.bun run typecheck,bun run structure:check,bun run skill:surface:check,bun run privacy:scan: passed.bun run --cwd docs-site build: 561 pages and 77,997 internal links checked.c8d7a0ef6934f6a9bb5d7f7d4299bfb278dde3ef: run 37149364066, pull_request event, attempt 1; all four test shards and aggregate CI succeeded.c8d7a0ef69preserves all semantic assertions, adds no-request/raw-error non-disclosure checks and corrects pending exit/flow identity. The full legacy account fixture plus new login-options tests passed 233 cases; typecheck passed. Independent fixture interdiff review passed. Current-head hosted CI subsequently passed. Independent functional/security/document reviews passed; the initial CodeRabbit success was a draft-skip status and is not counted as a code review.devlog/_plan/261003_cli_gui_parity/052_accounts_verification.md.Checklist