Skip to content

feat(cli): add model ordering and routing editor workflows - #6535

Merged
lidge-jun merged 13 commits into
devfrom
codex/cli-parity-models-routing
Oct 4, 2026
Merged

lidge-jun merged 13 commits into
devfrom
codex/cli-parity-models-routing

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add explicit live custom-model add/remove, model display-name overrides, picker ordering, routing-profile create/update/remove, structured combo target editing and JEV statistics. Extend offline help and the operating skill to the actual task/argument contracts.
  • Keep raw upstream IDs, stored custom IDs and public picker identities distinct. Refuse ambiguous deletion, preserve native-inclusive order until explicit reset, and require the caller's revision for profile updates. Confirmed deletes do not gain invented revision protection.
  • Preserve combo false/default values and unrelated settings during structured target replacement. Report saved-but-unconverged catalog outcomes and safe local JSON sync evidence without claiming rollback, successful application or nonexistent savings.
  • Manual stack layer 3, based on feat(cli): add live provider management and safe editor apply #6528 (codex/cli-parity-providers). Phase record: devlog/_plan/261003_cli_gui_parity/042_models_verification.md. Server routing algorithms and authentication are unchanged.

Verification

Stack refresh onto dev (lane L1, 2026-10-04; re-refreshed 2026-10-05 onto dev df61d03ecc), head 7d23f8a4a070fe8f47a95f265534f45cd5cdbe7d. Merged the refreshed parent. Resolved one conflict in src/cli/provider.ts: this layer's shared projectLocalSyncResult helper is kept and the parent's catalog-owner safety-warning projection now lives in src/cli/local-sync-result.ts, so provider add and models custom add/remove both surface it. Focused provider/models result and runtime test files passed (223 cases). Local checks at this head: bun scripts/file-size-ratchet.ts (pass; test-layout fixture now well under the 2000-line threshold after #6583), tests/test-layout.test.ts + tests/test-layout-tooling.test.ts (pass), bun run typecheck (pass), bun run structure:check (pass); on the stack top additionally skill:surface:check, privacy:scan and the skill/capability/ratchet test files (all pass). The full local suite was intentionally not run per maintainer instruction; broad and platform coverage is left to exact-head hosted CI: Cross-platform CI run 37217206834 (success at this head). Earlier-head CI results below are historical. Later dev moves (#6576, #6578, #6405, #6486, #6512, #6572, #6585, #6586, #6564) were merged in the same way; test-layout fixture conflicts were resolved as key unions, and this layer now packs only its own new entries in scripts/test-layout/layout.json four per line (JSON content unchanged; the file stays clear of the 2000-line threshold for unbaselined files once the stack lands).

Current-head hosted CI passed at 0b0f090cb2adece430496d7f0e8e1cfe9db37f1f: run 37159733452, pull_request event, attempt 1; all four test shards and aggregate ci succeeded. This manual layer targets codex/cli-parity-providers and contains its refreshed parent plus pinned dev 0818ea1812a028e1c14cd0b0511b44863407bc52. Earlier-head results below remain historical. Optional platform jobs skipped by scope are not claimed as executed. Correct remote and independent review findings were repaired and propagated upward; no PR was merged.

  • Independent architecture, general plan and security plan checks passed. Functional/security code reviews passed, including the targeted re-review after a real-handler test exposed unrelated combo settings being reset by target-file replacement.
  • Focused tests include actual isolated management handlers, observed-identity collisions, strict file/flag boundaries, real local sync outcomes, GUI sort conformance plus independent fixtures, server CAS/alias/deletion behavior and numeric root dispatch. The full local suite was not repeated due its resource cost across concurrent worktrees; exact-head hosted CI supplies broader and platform proof before readiness.
  • 25 actual CLI QA scenarios passed against an injected management fixture with all sockets forbidden. They cover live/local custom models, saved HTTP503, most-used/manual ordering and drift/native guards, profile create/update/stale/delete, explicit combo false/default fields, empty stats and invalid inputs. Live actions leave application-file hashes unchanged; only owned local-write fixtures change their own config. All child processes ended and temporary homes were removed.
  • Final source-bound gate at 728677beafe5aac87005f64575968ec28d303dea: 1,016 tests passed, 0 failed across 36 files. Typecheck, structure, generated skill, privacy and whitespace passed. Docs built 561 pages and validated 77,979 internal links. Exact-head hosted CI passed all four test shards and required checks. Skipped platform/path jobs were not executed and are not counted as passes. No live user proxy, credential, paid inference, release or deployment was used.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 33f23b27-ceb3-4b72-8922-f65d47699cb6
📥 Commits

Reviewing files that changed from the base of the PR and between a8d8562 and 432bc4d.

📒 Files selected for processing (58)
  • devlog/_plan/261003_cli_gui_parity/004_settings_coverage.md
  • devlog/_plan/261003_cli_gui_parity/008_task_ledger.json
  • devlog/_plan/261003_cli_gui_parity/040_models_routing.md
  • devlog/_plan/261003_cli_gui_parity/041_models_revalidation.md
  • devlog/_plan/261003_cli_gui_parity/042_models_verification.md
  • docs-site/src/content/docs/fr/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ja/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ko/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/reference/cli/agents.md
  • docs-site/src/content/docs/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/ru/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/tr/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/zh-cn/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/zh-tw/reference/cli/providers-accounts.md
  • scripts/test-layout/layout.json
  • skills/ocx/references/01_management_surface.md
  • skills/ocx/references/01_surface_agents-routing.md
  • skills/ocx/references/01_surface_providers-models.md
  • skills/ocx/references/02_json_shapes.md
  • skills/ocx/references/03_recipes.md
  • skills/ocx/references/04_failure_semantics.md
  • src/cli/capabilities-agents-routing.ts
  • src/cli/capabilities-provider-models.ts
  • src/cli/catalog-command-result.ts
  • src/cli/combo-input.ts
  • src/cli/combo-result.ts
  • src/cli/combo-stats.ts
  • src/cli/combo.ts
  • src/cli/local-sync-result.ts
  • src/cli/model-picker-ordering.ts
  • src/cli/models-custom-input.ts
  • src/cli/models-custom-runtime.ts
  • src/cli/models-order.ts
  • src/cli/models-runtime-subcommands.ts
  • src/cli/models-runtime.ts
  • src/cli/models.ts
  • src/cli/provider.ts
  • src/cli/registry.ts
  • src/cli/route-policy-write.ts
  • src/cli/route-policy.ts
  • src/server/management/route-registry.ts
  • structure/cli-management.md
  • tests/ci-workflows/skill-ocx-workflows.test.ts
  • tests/cli/cli-capabilities.test.ts
  • tests/cli/cli-capability-agent-workflows.test.ts
  • tests/cli/cli-capability-provider-workflows.test.ts
  • tests/cli/cli-catalog-command-result.test.ts
  • tests/cli/cli-combo-parity.test.ts
  • tests/cli/cli-combo-partial-update.test.ts
  • tests/cli/cli-combo-stats.test.ts
  • tests/cli/cli-headless-parity.test.ts
  • tests/cli/cli-models-custom-runtime.test.ts
  • tests/cli/cli-models-display-name.test.ts
  • tests/cli/cli-models-local-result.test.ts
  • tests/cli/cli-models-order.test.ts
  • tests/cli/cli-models.test.ts
  • tests/cli/cli-route-policy-write.test.ts
  • tests/fixtures/test-layout-expected.json
 _____________________________________________________________
< What, what, what, what, what, what, what, what, what, what? >
 -------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 3, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review October 3, 2026 18:41
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 3, 2026 18:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T18:46:51.150914Z 728677b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…s-routing

# Conflicts:
#	src/cli/provider.ts
…s-routing

Resolve src/cli/provider.ts: keep the shared projectLocalSyncResult helper and move the catalog-owner safety-warning projection into src/cli/local-sync-result.ts, so provider add and models custom add/remove both surface it.
…s-routing

Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
Base automatically changed from codex/cli-parity-providers to dev October 4, 2026 19:08
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration (lidge-jun, dev only) — 2026-10-04 landing train, lane L1 stack.

  • Head: 432bc4d — a tree-identical sync merge on top of e36d125 (merge commit of dev after the feat(cli): make existing management workflows discoverable #6526 squash / parent sync; git rev-parse <sha>^{tree} equal), so the CI evidence below covers the same content.
  • CI: Cross-platform CI run 37225570366 success at e36d125.
  • Union: static check against current dev (clean merge, layout registries parse, structure-ssot and file-size ratchet pass).
  • Review: model ordering and routing editor workflows.
  • Landed with a merge commit (allowed by the dev ruleset) so the remaining stack stays conflict-free after the feat(cli): make existing management workflows discoverable #6526 squash.
  • Full local suite intentionally not run per maintainer instruction.
  • scripts/ci/assert-mergeable-review.sh --maintainer-integration: OK.

@lidge-jun
lidge-jun merged commit 4cc48d9 into dev Oct 4, 2026
29 of 30 checks passed
@lidge-jun
lidge-jun deleted the codex/cli-parity-models-routing branch October 4, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant