fix(cli): keep restart rechecks within their deadline

[lidge-jun]

Summary

• A clock tick between two Date.now() calls could make restart replacement observation exceed its caller's deadline. Capture the clock once for both the remaining budget and absolute end.
• The deterministic regression supplies 1000 then 1001 with a deadline of 6000: the old code passes 6001 to the observer; the fixed code passes 6000. Existing timeouts and assertions are retained.
• Small prerequisite for the CLI UX stack (feat(cli): add explicit help paths and complete reference #6498 → feat(cli): organize help around common tasks #6500 → feat(cli): guide recovery from command typos #6503), after this boundary failed in hosted CI. No command syntax, configuration, authentication or release behavior changes.

Manual stack (bottom to top)

Order	PR	Layer
1	#6506	Restart deadline prerequisite
2	#6498	Explicit help paths and full reference
3	#6500	Compact root and family navigation
4	#6503	Contextual recovery

Integration order is bottom-up. The recorded local full-suite limitations remain disclosed below.

Verification

• Regression RED reproduced the exact 6001/6000 failure before the fix.
• bun test tests/windows/tray-proxy.test.ts: 43 passed, 0 failed, 117 assertions.
• bun run typecheck, bun run structure:check, bun run privacy:scan, and whitespace checks passed.
• Independent review covered all three changed files and five additional deadline boundaries: PASS. The fake clock is restored before awaiting; no live proxy or service was controlled.
• Current-head hosted CI has passed. The related UX stack records four failures from its full local run (three reproduced on its untouched baseline, one unresolved snapshot failure); this focused fix does not claim to resolve those or establish full local/platform readiness.

Final publication verification: head 19136566a30df90f8075cf64b44e895b3b769ecc; Cross-platform CI run 37116325157 (pull_request, attempt 1) completed successfully with all four Linux test shards and ci. The checkout tested by shard 1 was 0e5ff056b0718d82bc86d684621757186ccf7a99. Policy-skipped platform jobs are not claimed as passing platform validation.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Maintainer integration

The owner explicitly requested completion through merge. Integrating into dev under the maintainer-integration policy in MAINTAINERS.md; this is not a self-approval. Authenticated actor lidge-jun is a current maintainer with live admin access; the review gate reports no outstanding maintainer objection.

Head 19136566a30df90f8075cf64b44e895b3b769ecc passed CI 37116325157, including all four Linux shards and the aggregate. The tested checkout 0e5ff056b0718d82bc86d684621757186ccf7a99 has tree ae5351dc03ea760389527b4a1a89f2fb37912610, identical to the conflict-free merge-tree against current dev 3bae88cce7400e47a5e69f9fd28749ed25f919f6. The prior local full-suite limitations are preserved, not reported as a pass.

Summary by CodeRabbit

• Bug Fixes
  • Improved consistency when coordinating restart replacements, so the observation window uses a single, fixed time reference. This helps ensure replacement processes are observed within the intended deadline.
• Documentation
  • Clarified how local account imports and runtime credential resolution work, including that importing does not perform OAuth.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (2)

src/AGENTS.md — auto-discovered
structure/AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 44e64959-f4a3-4fd8-b8dc-33333c2f4e12

📥 Commits

Reviewing files that changed from the base of the PR and between 3bae88c and 1913656.

📒 Files selected for processing (3)

• src/cli/tray-proxy.ts
• structure/runtime.md
• tests/windows/tray-proxy.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

reobserveRestartReplacement now uses one captured time to calculate both the remaining re-observation window and its end time. The 1,500 ms minimum-window check remains. A regression test and runtime documentation cover the timing behavior.

Changes

Restart replacement re-observation

Layer / File(s)	Summary
Use one clock snapshot for the replacement deadline src/cli/tray-proxy.ts, tests/windows/tray-proxy.test.ts, structure/runtime.md	The re-observation calculation uses one Date.now() value for its window and end time. A regression test checks the deadline when clock reads advance and verifies that the live replacement is returned. The runtime entrypoint documents the behavior. The Orca import-contract sentence is joined across its link; its stated contract is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 19136

This is a small timing fix that keeps restart rechecks within their deadline. A regression test covers it and no concrete risks remain, so it looks safe to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: keeping restart replacement rechecks within their deadline.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Deterministic PR hygiene checks passed.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-03T13:32:10.331522Z	1913656	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.