Repository navigation
feat(cli): organize help around common tasks - #6500
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (18)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughRoot CLI help now displays a compact, grouped command index, while ChangesCLI Help Navigation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant User
participant handleProviderCommand
participant printSubcommandUsage
participant resolveHelpPath
participant stdout
participant stderr
User->>handleProviderCommand: request provider help or unknown action
handleProviderCommand->>printSubcommandUsage: request provider usage
printSubcommandUsage->>resolveHelpPath: resolve registry-backed provider help
resolveHelpPath-->>printSubcommandUsage: return help details
printSubcommandUsage->>stdout: write successful help
printSubcommandUsage->>stderr: write usage for an unknown action
Merge Risk: ⚪ Minimal · up to The compact help meets its layout limits, and the full reference remains available through --all. No identified issue prevents merging after normal checks. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The reviewed changes reorganize help and share command descriptions without expanding command authority or weakening security controls. The complete reference remains available separately. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 11 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
de02ff1 to
b82c5a9
Compare
aaf3672 to
13c0e82
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13c0e829df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
ocx help --allretains the full reference, including advanced recovery commands.codex/cli-ux-help-foundation; review only this layer's diff. Contextual recovery follows in the third layer.Manual stack (bottom to top)
Integration proceeds bottom-up under the owner's explicit merge request. Local full-suite limitations remain disclosed below.
Verification
bun run test:changed: 1,097 passed, 1 skipped, 0 failed across 46 files. The existing complete-reference invariant was migrated from compact output to full output without removing any assertions.011_verification.mdand021_verification.mdin the CLI UX plan unit. Current-head hosted checks are tracked separately for each PR.Final publication verification: head
13c0e829df104bc46082b06e2c29d37e89917cc6; Cross-platform CI run 37116382613 (pull_request, attempt 1) completed successfully with all four Linux test shards andci. The checkout tested by shard 1 was33d0a8bb9078826c164b40811c442364d1afef8f. Policy-skipped platform jobs are not claimed as passing platform validation.The cancelled duplicate run
37116382554is superseded by successful run37116382613; its cancelled jobs are not passing evidence.Checklist
Integration status
The owner explicitly requested merging the complete manual stack. This PR will be retargeted to
devafter its predecessor lands; any refreshed head must pass hosted CI before integration. The prior local full-suite failures remain disclosed and are not claimed as a pass.Local-suite failure attribution
All four previously recorded local-suite failures now reproduce on untouched baseline
4b98328dca. The three restart-lease failures were already baseline-confirmed. The remainingEISDIRis intests/codex-integration/injection-model-suggest-routes.test.ts:100, before the tested request: setup calls the bundled Codex catalog probe, whosecodex debug models --bundledsubprocess createsCODEX_HOME/tmp; the shallow snapshot attempts to read that directory as a file. The unchanged baseline test reproduced the identical failure in an isolated home. A controlled inherited-home / redirected-home / inherited-home experiment producedtmponly in the selected subprocess home. The baseline fixture matches Git blobef0dafba8dfe2cff3b7519453502d95a46b64925; the fixture and direct catalog producer are unchanged by this stack.This closes the previously unexplained attribution gap; it does not turn the failed full local run into a pass. No test skip, quarantine or retry-as-fix was added. Merge still requires successful current-head hosted CI and resolution of actionable reviews.
Codex review correction:
c89341793fchanges the provider usage header to the explicitly non-exhaustiveocx provider <subcommand>, so validresetsandkeychainactions are no longer contradicted.bun test tests/cli/cli-help-navigation.test.ts: 9 pass, 0 fail, 208 assertions;bun run typecheck: passed.Maintainer integration
The owner explicitly requested completion through merge. Integrating into
devunderMAINTAINERS.mdas authenticated current maintainerlidge-junwith live admin permission; this is not a self-approval. The diagnosed baseline failures remain disclosed. Original draft-only publication notes are superseded by this integration decision. The provider-usage finding was fixed and independently reviewed at the final head.Final head
c89341793f39b11e3719841b3ae994de0d4364eapassed Cross-platform CI 37126906934 (pull_request, attempt 1), including all four Linux shards and aggregateci. Tested checkout875828735615bb1daa77645048991fa2b4d78ce1has tree29f1c305005339d2397d9bcee7d497399c259853, identical to the conflict-free prospective merge with devb82b39018b48ad489110b4165ee2cd9ba30433d5after #6498. Superseded canceled CI runs do not provide passing evidence. Policy-skipped platform jobs are not counted as passes.Summary by CodeRabbit
--allfor the full command reference.