Repository navigation
feat(codex): list GPT-6.1 Sol as a self-described native - #6252
giulioleone097 wants to merge 1 commit into
Conversation
OpenAI released GPT-6.1 Sol on 2026-09-29. The authenticated Codex roster already serves it, but opencodex lists natives only from its own allowlist, so the model was missing from the picker. Pin the roster row captured at client_version=0.159.0 and register gpt-6.1-sol as an ungated, self-described native. It is not an alias of gpt-6-sol: the row ships its own instructions, a low default effort, multi_agent_reasoning_effort xhigh and a different Fast tier.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change adds GPT-6.1 Sol to the native Codex catalog. It includes a pinned roster entry, model settings, catalog registration, integration test coverage, and updates to the catalog and provider documentation. ChangesGPT-6.1 Sol native catalog
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This adds GPT-6.1 Sol to the native Codex model catalog with its own metadata. No concrete merge-blocking risk was found. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new offering follows the existing selection and credential safeguards. No bypass was identified, but availability enforcement outside this application could not be verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 24 / 80이 PR은 OpenAI가 2026-09-29에 낸 docs-site/.../providers.md - Sol/Luna는 표에 있는데 tests/.../gpt6-native-rows.test.ts - 새 모델의 라벨·창·사다리·지시문 분리는 잘 잡는다. 그런데 src/codex/data/roster-pinned-models.json - 파일 source 메모는 0.155.0(Sol/Luna)과 0.159.0(6.1)이 섞여 있다. 의도는 분명하다. 다만 라이브 로스터가 이미 메인테이너의 판단이 필요한 지점
너의 추천 카탈로그 등록 자체는 #5580 패턴과 맞고, 지시문/기본 effort 분리 테스트도 핵심을 잡는다. docs 표·문장만 고치고, 이 댓글은 grok-bot이 작성했습니다 |
Carry upstream PR lidge-jun#6252 at 038326c so the user override build includes the self-described native model. Address the maintainer review by adding the documentation table row and clear slug wording, and asserting the built catalog row and Fast tier. Keep the older Sol description unchanged as the review recommends. Focused catalog and discovery checks pass. GUI/package and installed runtime integrity checks pass. The docs build renders successfully but its final check reports nine broken links outside the edited page. Co-authored-by: Giulio Leone <giulioleone097@gmail.com> Signed-off-by: Bernardo Donadio <bcdonadio@bcdonadio.com>
|
Superseded by #6263, which pins the same GPT-6.1 Sol roster row and also covers the API-key, OpenRouter, Copilot and pricing rows. Closing this one; thanks for the review. |
Closes #6251
Summary
OpenAI released GPT-6.1 Sol on 2026-09-29 (https://openai.com/index/introducing-gpt-6-1-sol/). The authenticated Codex roster already serves it, but opencodex lists natives only from its own allowlist, so users cannot pick it.
This PR registers
gpt-6.1-solthe way #5580 registered Sol and Luna:src/codex/data/roster-pinned-models.json. It was captured fromchatgpt.com/backend-api/codex/models?client_version=0.159.0(main account) on 2026-09-29. It goes first, matching upstream's order (priority 1).NATIVE_GPT61_SOL_MODELis self-described and ungated. It is listed with the built-in natives and the main-drain sentinel set, backfilled throughDOCUMENTED_NATIVE_OPENAI_ADDITIONS, and given the GPT-6 context pair.It is not a capability alias of
gpt-6-sol, and theproviders.openai.modelsconfigured-native path is not a substitute. The 6.1 row ships:lowdefault effortmulti_agent_reasoning_effort: "xhigh"A configured native would present all four with Sol's values. Context (272,000 / 872,000), modalities and the low..ultra ladder match Sol.
No API-key registry rows or price estimates are added, the same scope #5580 kept.
Docs:
providers.mdgains a GPT-6.1 Sol paragraph.structure/catalog.mdnotes the third roster row, reflowed so the file stays at its 600-line budget.Note: the live roster now describes
gpt-6-solas "Previous generation workhorse model." The pinned Sol row still has the older description. I left it untouched to keep this PR focused.Verification
bun run typecheck: exit 0.bun run structure:check: passed.bun run privacy:scan: passed.bun scripts/test.ts tests/codex-integration/gpt6-native-rows.test.ts tests/claude-integration/claude-models-discovery.test.ts: 20 pass, 0 fail.gpt6-native-rows.test.tsnow covers 6.1 Sol's label, windows, ladder andlowdefault. It also asserts that 6.1 Sol resolves to its own instructions and not Sol's, and pins the roster file's slug order.bun run test:changed: 27,749 pass, 65 fail on this machine under load. Re-running only the 15 failing files: 773 pass, 6 fail. Those 6 also fail on a cleandevcheckout with the patch stashed:shutdown-launcher(3)server-auth(2)native-codex-toggle(1)They are pre-existing on this machine and not caused by this change. The full
bun run testwas not run; CI is the gate for the rest.Live, on released 2.71.0 without this patch:
codex exec -m gpt-6.1-solthrough the proxy returns 200 and the request log showsopenai/gpt-6.1-sol. The upstream model works, and only the catalog listing is missing. I did not run the patched build as a live proxy.Checklist
Summary by CodeRabbit
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.