Repository navigation
feat(dev-frontend): WCAG 2.2 AA owner and visual audit loop - #328
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50b118143a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,171 @@ | |||
| # WCAG 2.2 AA conformance check | |||
|
|
|||
| Read when someone asks whether a web UI meets WCAG 2.2 AA (or KWCAG, which follows it), | |||
There was a problem hiding this comment.
Separate KWCAG conformance from the WCAG 2.2 checklist
When the user asks for KWCAG conformance, this instruction routes the agent to a WCAG 2.2 AA checklist and its verdict rules as though the standards were interchangeable. KWCAG 2.2 is a separate Korean standard based on WCAG 2.1, with its own 33 inspection items, rather than the 55 criteria documented here. See the official standard listing and the government's description of its 33-item assessment. Remove the implied equivalence and require a KWCAG-specific checklist or explicit mapping before issuing a KWCAG verdict; otherwise an agent can complete this checklist without establishing the conformance the user actually requested.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed, fixed in ed63835. The opening line no longer calls KWCAG something that follows WCAG 2.2, and FE-WCAG22-03 (STRICT) now says this checklist does not decide KWCAG: KWCAG 2.2 (KS X OT0003, 2022) is built on WCAG 2.1 with 33 inspection items, so a KWCAG verdict needs that item list or an explicit item-by-item mapping that names unmapped items. Merged up into #329 (9e68ba5).
|
✅ Target branch corrected This pull request now targets The |
Asking an agent "does this page meet WCAG 2.2 AA?" got contrast ratios and a 44 px rule from scattered files, with no owner for the 55 A/AA criteria, nothing on the six criteria new in 2.2, and Lighthouse scores treated as a pass. Fixing a visual audit had no per-violation verifier or before/after contract either. This PR adds both owners to dev-frontend.
Stack: 2 of 3. Base
docs/frontend-skill-audit-uiux(#327). Next: #329.Before / After: the documented check on a seeded page
The same pagination fixture, 390 px wide. Before: two 12 × 12 px links and an image without
alt. After: 44 px targets with spacing and analttext.[{"id":"image-alt","nodes":1},{"id":"target-size","nodes":2}]exit 1[]exit 0Output of the script in
wcag22-aa.md(axe-core 4.14.0, tagswcag2a,wcag2aa,wcag21a,wcag21aa,wcag22aa), saved inevidence/axe-fixture/run.log.target-sizeis WCAG 2.5.8, one of the 2.2 additions.What changed
wcag22-aa.md: 55 criteria (31 A, 24 AA) with axe rules or a manual check each; FE-WCAG22-01 (STRICT) forbids conformance claims from automated runs, scores or screenshotsbrowser.newContext())visual-audit-loop.md: violation ledger (V-ids carrying GAP/EV ids), verifier and pass rule written before the fix (FE-VISUAL-AUDIT-02), recapture after the last edit, closure gate (03), PR Before/After section, cxc-loop routing with--surface webcriteriaRouting rows in
SKILL.mdandtopic-index.md; pointers in role-boundaries, visual-verification, preflight-full and anti-slop-enforcement.Validation
cxc receipt test.