Prevent options being a string rather than JSON#4146
Prevent options being a string rather than JSON#4146bjester merged 1 commit intolearningequality:hotfixesfrom
Conversation
|
Looking at the blame history, seems this was a |
|
Kolibri appears to want a text field, not JSON https://github.com/learningequality/kolibri/blob/develop/kolibri/core/content/contentschema/versions/content_schema_current.py#L82 |
|
When I updated the Kolibri models for use in both kolibri_public and kolibri_content, I also used the Kolibri JSONField implementation (which saves to a text field under the hood): https://github.com/learningequality/kolibri/blob/develop/kolibri/core/content/base_models.py#L133 This was to ensure proper serialization to the API endpoints, but I missed the json.dumps that had previously been used when it had been set as a TextField rather than the JSONField (which handles the json.dumps internally) - so it was getting double json.dumpsed. |
|
Okay that makes sense. Lets make sure that we also QA channel import just in case |
Jason.Jason.Jason.Jason.Jason.Jason.Jason.Jason.Jason.Jason.mp4 |
Summary
Description of the change(s) you made
Manual verification steps performed
Fixes #4141